Merge "Add trigger-with-no-params for join-trigger"

jenkins_jobs/modules/publishers.py

@@ -269,6 +269,8 @@ def trigger_parameterized_builds(parser, xml_parent, data):
     :arg str property-file: Use properties from file (optional)
     :arg bool fail-on-missing: Blocks the triggering of the downstream jobs
       if any of the files are not found in the workspace (default 'False')
+    :arg bool trigger-with-no-params: Trigger a build even when there are
+      currently no parameters defined (default 'False')
     :arg str restrict-matrix-project: Filter that restricts the subset
         of the combinations that the downstream project will run (optional)
     :arg str node-label-name: Specify the Name for the NodeLabel parameter.
@@ -370,7 +372,8 @@ def trigger_parameterized_builds(parser, xml_parent, data):
         condition.text = project_def.get('condition', 'ALWAYS')
         trigger_with_no_params = XML.SubElement(tconfig,
                                                 'triggerWithNoParameters')
-        trigger_with_no_params.text = 'false'
+        trigger_with_no_params.text = str(
+            project_def.get('trigger-with-no-params', False)).lower()
 
 
 def trigger(parser, xml_parent, data):

tests/publishers/fixtures/join-trigger001.xml

@@ -12,7 +12,7 @@
               </configs>
               <projects>archive</projects>
               <condition>ALWAYS</condition>
-              <triggerWithNoParameters>false</triggerWithNoParameters>
+              <triggerWithNoParameters>true</triggerWithNoParameters>
             </hudson.plugins.parameterizedtrigger.BuildTriggerConfig>
             <hudson.plugins.parameterizedtrigger.BuildTriggerConfig>
               <configs>

tests/publishers/fixtures/join-trigger001.yaml

@@ -8,5 +8,7 @@ publishers:
         - trigger-parameterized-builds:
           - project: archive
             current-parameters: true
+            trigger-with-no-params: true
           - project: cleanup
             current-parameters: true
+            trigger-with-no-params: false