jjb/jenkins-job-builder
Code Issues Proposed changes

Merge "Warn only once for masked definitions"

Browse Source
This commit is contained in:
Jenkins 2016-01-07 14:49:11 +00:00 committed by Gerrit Code Review
commit 619ea5185a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
jenkins_jobs/registry.py
View File

@ -35,6 +35,7 @@ class ModuleRegistry(object):
self.modules_by_component_type = {}
self.handlers = {}
self.global_config = config
self.masked_warned = {}
if plugins_list is None:
self.plugins_dict = {}
@ -226,7 +227,9 @@ class ModuleRegistry(object):
# check for macro first
component = parser.data.get(component_type, {}).get(name)
if component:
if name in eps:
if name in eps and name not in self.masked_warned:
# Warn only once for each macro
self.masked_warned[name] = True
logger.warn("You have a macro ('%s') defined for '%s' "
"component type that is masking an inbuilt "
"definition" % (name, component_type))