jjb/jenkins-job-builder
Code Issues Proposed changes

Merge "Default slack to newest plugin config format"

Browse Source
This commit is contained in:
Jenkins 2017-09-20 00:40:51 +00:00 committed by Gerrit Code Review
commit 646c61bb34
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
jenkins_jobs/modules/publishers.py
View File

@ -6482,7 +6482,9 @@ def slack(registry, xml_parent, data):
logger = logging.getLogger(__name__)
plugin_info = registry.get_plugin_info('Slack Notification Plugin')
plugin_ver = pkg_resources.parse_version(plugin_info.get('version', "0"))
# Note: Assume latest version of plugin is preferred config format
plugin_ver = pkg_resources.parse_version(
plugin_info.get('version', str(sys.maxsize)))
mapping = (
('team-domain', 'teamDomain', ''),

3
tests/publishers/fixtures/slack001.plugins_info.yaml Normal file
View File

@ -0,0 +1,3 @@
- longName: 'Slack Notification Plugin'
shortName: 'slack'
version: "1.0"

3
tests/publishers/fixtures/slack002.plugins_info.yaml Normal file
View File

@ -0,0 +1,3 @@
- longName: 'Slack Notification Plugin'
shortName: 'slack'
version: "1.0"