jjb/jenkins-job-builder
Code Issues Proposed changes

Merge "Update custom_tools to use convert_to_xml()"

Browse Source
This commit is contained in:
Jenkins 2017-08-03 04:58:32 +00:00 committed by Gerrit Code Review
commit d4ec195645
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
jenkins_jobs/modules/wrappers.py
View File

@ -1797,17 +1797,16 @@ def custom_tools(registry, xml_parent, data):
tool_node = base + '.CustomToolInstallWrapper_-SelectedTool'
for tool in tools:
tool_wrapper = XML.SubElement(wrapper_tools, tool_node)
XML.SubElement(tool_wrapper, 'name').text = str(tool)
mapping = [('', 'name', tool)]
convert_mapping_to_xml(tool_wrapper, data, mapping, fail_required=True)
opts = XML.SubElement(wrapper,
'multiconfigOptions')
skip_install = str(data.get('skip-master-install', 'false'))
XML.SubElement(opts,
'skipMasterInstallation').text = skip_install
mapping = [('skip-master-install', 'skipMasterInstallation', False)]
convert_mapping_to_xml(opts, data, mapping, fail_required=True)
convert_home = str(data.get('convert-homes-to-upper', 'false'))
XML.SubElement(wrapper,
'convertHomesToUppercase').text = convert_home
mapping = [('convert-homes-to-upper', 'convertHomesToUppercase', False)]
convert_mapping_to_xml(wrapper, data, mapping, fail_required=True)
def nodejs_installator(registry, xml_parent, data):

6
tests/wrappers/fixtures/custom-tools001.xml
View File

@ -8,9 +8,9 @@
</com.cloudbees.jenkins.plugins.customtools.CustomToolInstallWrapper_-SelectedTool>
</selectedTools>
<multiconfigOptions>
<skipMasterInstallation>True</skipMasterInstallation>
<skipMasterInstallation>true</skipMasterInstallation>
</multiconfigOptions>
<convertHomesToUppercase>True</convertHomesToUppercase>
<convertHomesToUppercase>true</convertHomesToUppercase>
</com.cloudbees.jenkins.plugins.customtools.CustomToolInstallWrapper>
</buildWrappers>
</project>
</project>