jjb/jenkins-job-builder
Code Issues Proposed changes

Merge "Sort views list jobs"

Browse Source
This commit is contained in:
Zuul 2018-04-12 20:45:10 +00:00 committed by Gerrit Code Review
commit d90320440c
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jenkins_jobs/modules/view_list.py
View File

@ -144,6 +144,7 @@ class List(jenkins_jobs.modules.base.Base):
XML.SubElement(jn_xml, 'comparator', {'class': XML.SubElement(jn_xml, 'comparator', {'class':
'hudson.util.CaseInsensitiveComparator'}) 'hudson.util.CaseInsensitiveComparator'})
if jobnames is not None: if jobnames is not None:
jobnames = sorted(jobnames) # Job names must be sorted in the xml
for jobname in jobnames: for jobname in jobnames:
XML.SubElement(jn_xml, 'string').text = str(jobname) XML.SubElement(jn_xml, 'string').text = str(jobname)

2
tests/views/fixtures/view_list001.yaml
View File

@ -5,8 +5,8 @@ filter-executors: true
filter-queue: true filter-queue: true
job-name: job-name:
- job-name-1 - job-name-1
- job-name-2
- job-name-3 - job-name-3
- job-name-2
columns: columns:
- status - status
- weather - weather