jjb/jenkins-job-builder
Code Issues Proposed changes

Simplify delete by removing unnecessary loop

Browse Source 
Change-Id: Ic0d2ee0863c012bba22599e7be94718033c4aa97
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
This commit is contained in:
Thanh Ha 2016-08-19 11:41:31 -04:00 committed by Darragh Bailey
parent b62e2ea0b6
commit e47098d89d
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
jenkins_jobs/cli/subcommand/delete.py
View File

@ -41,16 +41,14 @@ class DeleteSubCommand(base.BaseSubCommand):
builder = JenkinsManager(jjb_config) builder = JenkinsManager(jjb_config)
fn = options.path fn = options.path
registry = ModuleRegistry(jjb_config, builder.plugins_list) registry = ModuleRegistry(jjb_config, builder.plugins_list)
for jobs_glob in options.name: parser = YamlParser(jjb_config)
parser = YamlParser(jjb_config)
if fn: if fn:
parser.load_files(fn) parser.load_files(fn)
parser.expandYaml(registry, [jobs_glob]) parser.expandYaml(registry, options.name)
jobs = [j['name'] for j in parser.jobs] jobs = [j['name'] for j in parser.jobs]
else: else:
jobs = [jobs_glob] jobs = options.name
builder.delete_jobs(jobs) builder.delete_jobs(jobs)