remove old queries

this whole theory of keeping old queries around was a better
theory than practice, especially given that we currently have nearly
60 open queries. We also change files and formats often enough that
the old queries really don't bring any value to the table.

remove support for soft delete on queries to prevent this debt from
building up further.

Change-Id: I3f09358133463d1650cc755cd6a39964f79c7fc8

elastic_recheck/loader.py

@@ -25,7 +25,7 @@ import yaml
 LOG = logging.getLogger('recheckwatchbot')
 
 
-def load(directory='queries', skip_resolved=True):
+def load(directory='queries'):
     """Load queries from a set of yaml files in a directory."""
     bugs = glob.glob("%s/*.yaml" % directory)
     data = []
@@ -33,6 +33,5 @@ def load(directory='queries', skip_resolved=True):
         bugnum = os.path.basename(fname).rstrip('.yaml')
         query = yaml.load(open(fname).read())
         query['bug'] = bugnum
-        if not (skip_resolved and 'resolved_at' in query):
-            data.append(query)
+        data.append(query)
     return data

elastic_recheck/tests/unit/test_load_queries.py

@@ -40,13 +40,3 @@ class TestLoadQueries(tests.TestCase):
             # Use assertTrue because you can specify a custom message
             self.assertTrue("filename:\"logs/screen-" not in q['query'],
                             msg=("for bug %s" % q['bug']))
-
-    def test_load_queries_all(self):
-        queries = loader.load("queries", skip_resolved=False)
-
-        # Note(sdague): the current number of queries, if you delete a file
-        # you will need to change this
-        self.assertGreater(len(queries), 59)
-        for q in queries:
-            self.assertIsNotNone(q['bug'])
-            self.assertIsNotNone(q['query'])

queries/1177134.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"[ERROR] /opt/stack/old/devstack/exercises/bundle.sh:61
-  Image ami-00000001 not available within 15 seconds"
-  AND filename:"console.html"
-resolved_at: "Sun Jan 19 18:36:37 PST 2014"

queries/1191960.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"Exit code: 5"
-  AND message:" sudo cinder-rootwrap /etc/cinder/rootwrap.conf lvremove -f"
-  AND filename:logs*screen-c-vol.txt
-resolved_at: "Tue Dec 10 12:08:42 EST 2013"

queries/1235486.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"update or delete on table \"networks\" violates foreign key constraint"
-  AND filename:logs*screen-q-svc.txt
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1239637.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"DBError: (IntegrityError) null value in column \"network_id\"
-  violates not-null constraint"
-  AND filename:logs*screen-q-svc.txt
-resolved_at: "Tue Dec 10 12:08:42 EST 2013"

queries/1239856.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:" Registry client request" AND message:"raised ClientConnectionError"
-  AND filename:logs*screen-g-api.txt
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1244255.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"NovaException: Unexpected vif_type=binding_failed"
-  AND filename:logs*screen-n-cpu.txt
-resolved_at: "Thu Feb 13 17:06:53 PST 2014"

queries/1251512.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"test_get_console_output"
-  AND message:"raise MismatchError(matchee, matcher, mismatch, verbose)"
-  AND filename:"console.html"
-resolved_at: "Tue Dec 10 12:08:42 EST 2013"

queries/1251784.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"Connection to neutron failed: Maximum attempts reached"
-  AND filename:logs*screen-n-cpu.txt
-resolved_at: "Tue Dec 10 12:08:42 EST 2013"

queries/1251920.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"assertionerror: console output was empty"
-  AND filename:"console.html"
-resolved_at: "Tue Dec 10 12:08:42 EST 2013"

queries/1252514.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"Got error from Swift: put_object"
-  AND filename:logs*screen-g-api.txt
-resolved_at: "Tue Dec 10 12:08:42 EST 2013"

queries/1256970.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"Failure uploading bundle bundle.img to testbucket"
-  AND filename:"console.html"
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1259907.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"Failed to upload testbucket/bundle.img.manifest.xml"
-  AND filename:"console.html"
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1260371.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"urlopen error _ssl.c:489: The handshake operation timed out"
-  AND filename:"console.html"
-resolved_at: "Sun Jan 19 18:36:37 PST 2014"

queries/1261253.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"No distributions at all found for oslo.messaging>=1.2.0a11"
-  AND filename:"console.html"
-resolved_at: "Fri Feb  7 17:06:16 PST 2014"

queries/1261433.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"Unexpected error occurred serving API: Stack heat-tempest-"
-  AND message:"already has an action (DELETE) in progress."
-  AND filename:logs*screen-h-api.txt
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1261554.yaml

@@ -1,3 +0,0 @@
-query: >
-  message:"keystoneclient.middleware.auth_token ValueError: No JSON object could be decoded"
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1261731.yaml

@@ -1,3 +0,0 @@
-query: >
-  message:"Unable to deactivate open stack--volumes-_snapshot"
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1262154.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"Deadlock found when trying to get lock"
-  AND filename:logs*screen-n-api.txt
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1262613.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"BadRequest: Unable to find security_group with name 'secgroup_general--tempest-"
-  AND filename:"console.html"
-resolved_at: "Mon Jan  6 13:20:28 PST 2014"

queries/1263032.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"nova.api.openstack Timeout: Timeout while waiting on RPC response - topic: \""
-  AND message:", RPC method: \"get_console_output\""
-  AND filename:logs*screen-n-api.txt
-resolved_at: "Sun Jan 19 18:36:37 PST 2014"

queries/1265672.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"Invalid input received: Invalid input received: Availability zone"
-  AND filename:"console.html"
-resolved_at: "Thu Feb 13 17:06:53 PST 2014"

queries/1266711.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"AttributeError: virConnect instance has no attribute 'registerCloseCallback'"
-  AND project:"openstack/nova"
-  AND filename:console.html
-resolved_at: "Fri Feb  7 17:06:16 PST 2014"

queries/1267326.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"Unexpected number of images for"
-  AND message:"test_create_backup; was the oldest backup not yet deleted? Image list:"
-  AND filename:"console.html"
-resolved_at: "Thu Feb 13 17:06:53 PST 2014"

queries/1268631.yaml

@@ -1,5 +0,0 @@
-query: >
-  build_name:*-horizon-python*
-  AND message:"UnknownMethodCallError('management_url')"
-  AND filename:"console.html"
-resolved_at: "Fri Feb  7 17:06:16 PST 2014"

queries/1270212.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"KeyError: 'svc_type'"
-  AND filename:console.html AND project:"openstack/neutron"
-resolved_at: "Thu Feb 13 17:06:53 PST 2014"

queries/1270608.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"Error: iSCSI device not found at /dev/disk/by-path/ip-127.0.0.1:3260-iscsi-iqn.2010-10.org.openstack:volume-"
-  AND filename:logs*screen-n-cpu.txt
-resolved_at: "Thu Feb 13 17:06:53 PST 2014"

queries/1270654.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"test_different_fname_concurrency"
-  AND build_name:gate-nova-python2*
-  AND filename:"console.html"
-resolved_at: "Fri Feb  7 17:06:16 PST 2014"

queries/1270680.yaml

@@ -1,6 +0,0 @@
-query: >
-  message:"TRACE nova.api.openstack"
-  AND message:"InstanceNotFound: Instance"
-  AND message:"v3/pci.py"
-  AND filename:logs*screen-n-api.txt
-resolved_at: "Fri Feb  7 17:06:16 PST 2014"

queries/1270693.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"AssertionError: _last_vol_usage_poll was not properly updated"
-  AND filename:"console.html"
-resolved_at: "Fri Feb  7 17:06:16 PST 2014"

queries/1271331.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"FAIL: nova.tests.db.test_sqlite.TestSqlite.test_big_int_mapping"
-  AND filename:"console.html"
-resolved_at: "Fri Feb  7 17:06:16 PST 2014"

queries/1271664.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"already exists in volume group"
-  AND message:"sudo cinder-rootwrap /etc/cinder/rootwrap.conf lvcreate -n "
-  AND filename:"console.html"
-resolved_at: "Fri Feb  7 17:06:16 PST 2014"

queries/1274056.yaml

@@ -1,5 +0,0 @@
-query: >
-  (message:"ImportError: cannot import name all"
-   OR message:"error: option --slowest not recognized")
-  AND filename:"console.html"
-resolved_at: "Thu Feb 13 17:06:53 PST 2014"

queries/1274121.yaml

@@ -1,5 +0,0 @@
-query: >
-  message:"instance_id" AND
-  message:"could not be found as device id on any ports"
-  AND filename:logs*screen-n-api.txt
-resolved_at: "Thu Feb 13 17:06:53 PST 2014"

queries/1274731.yaml

@@ -1,4 +0,0 @@
-query: >
-  message:"Could not find a version that satisfies the requirement psutil>1.1.0"
-  AND filename:console.html
-resolved_at: "Thu Feb 13 17:06:53 PST 2014"