From 6d862c4a8443e405f77834103d0e0293568cd209 Mon Sep 17 00:00:00 2001
From: Matt Riedemann <mriedem@us.ibm.com>
Date: Mon, 15 Feb 2016 08:46:21 -0800
Subject: [PATCH] Mark non-voting jobs in the graph

Commit e456a7afca0168a1cc408a3c30d6067b8c2ec169 added the
'allow-nonvoting' key to query yaml files so that we can
show non-voting job failures in the graph.

This change builds on that by displaying in the graph,
for non-voting job queries only based on that key, when a
job is non-voting with a simple "Voting: False" line.

Since the default behavior is to filter out non-voting
job results in all of the queries, we don't show anything
special in the graph for voting jobs since it would just
clutter up the output (non-voting is the exceptional case
we want to display).

Change-Id: Ibd75c6244abd10ad7cc491b4453339ad326a11ed
---
 elastic_recheck/cmd/graph.py | 3 ++-
 web/share/gate.html          | 5 +++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/elastic_recheck/cmd/graph.py b/elastic_recheck/cmd/graph.py
index d317ed26..9aee62f1 100755
--- a/elastic_recheck/cmd/graph.py
+++ b/elastic_recheck/cmd/graph.py
@@ -178,7 +178,8 @@ def main():
                    bug_data=bug_data,
                    fails=0,
                    fails24=0,
-                   data=[])
+                   data=[],
+                   voting=(False if query.get('allow-nonvoting') else True))
         buglist.append(bug)
         try:
             results = classifier.hits_by_query(query['query'],
diff --git a/web/share/gate.html b/web/share/gate.html
index d9bccf10..602f5b38 100644
--- a/web/share/gate.html
+++ b/web/share/gate.html
@@ -61,6 +61,11 @@
            <h3>{{bug.fails24}} fails in 24 hrs / {{bug.fails}} fails in
              10 days</h3>
            <h3>Projects: {{bug.bug_data.affects}}</h3>
+           <!-- only display that a job is non-voting since voting:1 is the
+                default filter -->
+           {{#unless bug.voting}}
+           <h3>Voting: False</h3>
+           {{/unless}}
            {{#if bug.bug_data.reviews}}
            <h3 class="openreviews">Open Reviews:</h3>
            <div class="openreviews">