From cd7f0d0a1438f66ba25533287085047b5951a3eb Mon Sep 17 00:00:00 2001
From: Joe Gordon <joe.gordon0@gmail.com>
Date: Fri, 14 Feb 2014 19:00:04 -0800
Subject: [PATCH] Add test to make sure filename's work with with grenade

Grenade screen logs are stored in logs/new/ and logs/old/ instead of
just logs, so add a check to make sure no queries use
'filename:"logs/screen-' they should instead use 'filename:logs*screen-'

Change-Id: I27916dc193fd0478091540f4b5088593a2d4624b
---
 elastic_recheck/tests/unit/test_load_queries.py | 11 +++++++++++
 queries/1275500.yaml                            |  2 +-
 queries/1278416.yaml                            |  2 +-
 queries/1280072.yaml                            |  2 +-
 4 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/elastic_recheck/tests/unit/test_load_queries.py b/elastic_recheck/tests/unit/test_load_queries.py
index cba66235..a8068450 100644
--- a/elastic_recheck/tests/unit/test_load_queries.py
+++ b/elastic_recheck/tests/unit/test_load_queries.py
@@ -30,6 +30,17 @@ class TestLoadQueries(tests.TestCase):
             self.assertIsNotNone(q['bug'])
             self.assertIsNotNone(q['query'])
 
+    def test_grenade_compat(self):
+        # grenade logs are in logs/new/ and logs/old, while devstack is in
+        # logs/. To make sure queries will work with both, one should use
+        # filename:logs*screen... (no quotes)
+        queries = loader.load("queries")
+
+        for q in queries:
+            # Use assertTrue because you can specify a custom message
+            self.assertTrue("filename:\"logs/screen-" not in q['query'],
+                            msg=("for bug %s" % q['bug']))
+
     def test_load_queries_all(self):
         queries = loader.load("queries", skip_resolved=False)
 
diff --git a/queries/1275500.yaml b/queries/1275500.yaml
index 9e7190f4..d4dda3dc 100644
--- a/queries/1275500.yaml
+++ b/queries/1275500.yaml
@@ -1,6 +1,6 @@
 query: >
   message:"Network filter not found"
   AND message:"libvirt"
-  AND filename:"logs/screen-n-cpu.txt"
+  AND filename:logs*screen-n-cpu.txt
   AND module:"nova.compute.manager"
 
diff --git a/queries/1278416.yaml b/queries/1278416.yaml
index 0d63e4ee..c351933e 100644
--- a/queries/1278416.yaml
+++ b/queries/1278416.yaml
@@ -1,4 +1,4 @@
 query: >
   message:"remove_iscsi_target"
   AND message:"os.unlink"
-  AND filename:"logs/screen-c-vol.txt"
+  AND filename:logs*screen-c-vol.txt
diff --git a/queries/1280072.yaml b/queries/1280072.yaml
index 0a8a8c44..5614eceb 100644
--- a/queries/1280072.yaml
+++ b/queries/1280072.yaml
@@ -1,4 +1,4 @@
 query: >
   message:"Backend storage for image"
   AND message:"disconnected after writing only"
-  AND filename:"logs/screen-g-api.txt"
+  AND filename:logs*screen-g-api.txt