From ce524a6c01122c66db4b48e6ca34dc9b67cd7e4f Mon Sep 17 00:00:00 2001 From: Sean Dague Date: Mon, 10 Mar 2014 09:52:50 -0400 Subject: [PATCH] mock out lp in tests that don't really need it launchpad lib is just largely responsible for causing problems in tests by racing on setting up directories. When we don't need it just mock it out. Change-Id: Ie16019b7c6e566ad55258d14f791c1f10410c4db --- elastic_recheck/tests/unit/test_bot.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/elastic_recheck/tests/unit/test_bot.py b/elastic_recheck/tests/unit/test_bot.py index e3cfd221..a9f0335f 100644 --- a/elastic_recheck/tests/unit/test_bot.py +++ b/elastic_recheck/tests/unit/test_bot.py @@ -16,30 +16,29 @@ import ConfigParser import unittest import yaml +import mock + from elastic_recheck import bot # NOTE(mtreinish) Using unittest here because testtools TestCase.assertRaises # doesn't support using it as a context manager class TestBot(unittest.TestCase): - def setUp(self): super(TestBot, self).setUp() self.fake_config = ConfigParser.ConfigParser({'server_password': None}) self._set_fake_config() self.channel_config = bot.ChannelConfig(yaml.load( open('recheckwatchbot.yaml'))) - self.recheck_watch = bot.RecheckWatch(None, self.channel_config, - self.fake_config.get('gerrit', - 'user'), - self.fake_config.get( - 'gerrit', - 'query_file'), - self.fake_config.get('gerrit', - 'host'), - self.fake_config.get('gerrit', - 'key'), - False) + with mock.patch('launchpadlib.launchpad.Launchpad'): + self.recheck_watch = bot.RecheckWatch( + None, + self.channel_config, + self.fake_config.get('gerrit', 'user'), + self.fake_config.get('gerrit', 'query_file'), + self.fake_config.get('gerrit', 'host'), + self.fake_config.get('gerrit', 'key'), + False) def _set_fake_config(self): self.fake_config.add_section('ircbot')