openstack/ansible-config_template
Code Issues Proposed changes

Remove xrange for run both Python 2 and Python 3

Browse Source 
In python 3, range() does what xrange() used to do and xrange() does not
exist. If you want to write code that will run on both Python 2 and
Python 3, you can't use xrange().

range() can actually be faster in some cases - eg. if iterating over the
same sequence multiple times. xrange() has to reconstruct the integer
object every time, but range() will have real integer objects.
(It will always perform worse in terms of memory however)

xrange() isn't usable in all cases where a real list is needed.
For instance, it doesn't support slices, or any list methods.

Change-Id: I033289359882c08185d59d13fa0b994c4566185a
This commit is contained in:
Luong Anh Tuan 2016-10-12 12:38:48 +07:00
parent 2e4aeaa007
commit 831103935b
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
library/dist_sort
View File

@ -118,7 +118,7 @@ class DistSort(object):
src_list = self.params['src_list'].split(self.params['delimiter']) src_list = self.params['src_list'].split(self.params['delimiter'])
index += self.params['sort_modifier'] index += self.params['sort_modifier']
for _ in xrange(index % len(src_list)): for _ in range(index % len(src_list)):
src_list.append(src_list.pop(0)) src_list.append(src_list.pop(0))
return self.params['delimiter'].join(src_list) return self.params['delimiter'].join(src_list)

4
library/memcached
View File

@ -260,7 +260,7 @@ class Memcached(object):
key_name = self.module.params['name'] key_name = self.module.params['name']
get_keys = [ get_keys = [
'%s.%s' % (key_name, i) for i in xrange(MAX_MEMCACHED_CHUNKS) '%s.%s' % (key_name, i) for i in range(MAX_MEMCACHED_CHUNKS)
] ]
self.mc.delete_multi(get_keys) self.mc.delete_multi(get_keys)
value = self.mc.get_multi(get_keys) value = self.mc.get_multi(get_keys)
@ -419,7 +419,7 @@ class Memcached(object):
key_name = self.module.params['name'] key_name = self.module.params['name']
get_keys = [ get_keys = [
'%s.%s' % (key_name, i) for i in xrange(MAX_MEMCACHED_CHUNKS) '%s.%s' % (key_name, i) for i in range(MAX_MEMCACHED_CHUNKS)
] ]
multi_value = self.mc.get_multi(get_keys) multi_value = self.mc.get_multi(get_keys)
if multi_value: if multi_value: