09c76e2380
The config_template comment parser will now respect all comments in INI files, as they are written. This will ensure spacing, paragraphs, and other comments bits that may be in an INI file remain intact, even when overriding options and sections. With this feature we'll now be able to insert options in OSLO config generated files without truncating or making a mess of the file structure. This is an internal enhancement and requires no change from the operator or from within any ansible task. To ensure enhanced comments are working, new tests have been added which will run though all of the `config_template` INI file functions using a mock service file. Existing tests for the old comment structure has been removed. This includes tests that were running redundant tasks for file diffs or expected the only style, merged, comment layout. All of the tests have been broken out into descriptive task files. This was largely done for readability. It was difficult to see what tests we had and how I needed to extend them to test the enhanced comments functionality given the INI type tests were all thoughout the `tests/test-common-tasks.yml`. Now that the files have been broken out developers will easily be able to audit our tests making it simple to extend. Change-Id: Ia6cdc215c35fa9ac45b718c211616a9887a74e37 Signed-off-by: Kevin Carter <kecarter@redhat.com>
9 lines
460 B
YAML
9 lines
460 B
YAML
---
|
|
features:
|
|
- The `config_template` action plugin will now search for options within a
|
|
given section that may be commented within an INI file, and if a an option is
|
|
following the OSLO config pattern, '#OPTION_KEY...' pattern, `config_template`
|
|
will insert the override one line after the comment. This provides operators
|
|
the ability to see in service options and any comments regarding the option
|
|
within the configuration file on-disk.
|