Only remove old services after they are stopped

Otherwise Ansible won't be able to stop them.

Change-Id: I990f5659ce501fa8ed95c2b18723189fe10f05d3

playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml

@@ -264,14 +264,6 @@
     service_name: 'ironic'
     config_file: '/etc/ironic/ironic.conf'
 
-- name: "Remove old ironic services"
-  file:
-    path: "{{ init_dest_dir }}{{ item }}.service"
-    state: absent
-  loop:
-    - ironic-api
-    - ironic-conductor
-
 - name: "Create and populate /tftpboot"
   import_tasks: create_tftpboot.yml
 

playbooks/roles/bifrost-ironic-install/tasks/start.yml

@@ -40,6 +40,14 @@
     - ironic-api
     - ironic-conductor
 
+- name: "Remove old ironic services"
+  file:
+    path: "{{ init_dest_dir }}{{ item }}.service"
+    state: absent
+  loop:
+    - ironic-api
+    - ironic-conductor
+
 - name: "Start ironic"
   service:
     name: ironic

releasenotes/notes/service-upgrade-54fda4d86e9d7575.yaml

@@ -0,0 +1,7 @@
+---
+issues:
+  - |
+    A bug in the upgrade logic could leave the old ``ironic-api`` and
+    ``ironic-conductor`` services running. It has been fixed, but if you
+    have already upgraded to an affected version, you need to stop the
+    services manually using ``systemctl``.