From 0f5e330b2b7493efddc70046c847bb05d78caa36 Mon Sep 17 00:00:00 2001 From: zhubx007 Date: Tue, 14 Aug 2018 21:17:12 +0800 Subject: [PATCH] [Docs] Update some links for Gerrit of Code Reviews Fix the same link issue of 'Development Workflow' and 'Gerrit Workflow Quick Reference'. Replace 'Gerrit Workflow Quick Reference' with 'Getting Started' to match the description. And add 'Quick Reference' and it's real link. Change-Id: Id1945123a510dd0db8ed375978d67a206f218537 --- doc/source/contributor/attach_detach_conventions.rst | 2 +- doc/source/contributor/gerrit.rst | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/doc/source/contributor/attach_detach_conventions.rst b/doc/source/contributor/attach_detach_conventions.rst index 9ff31c41751..deb101db2d9 100644 --- a/doc/source/contributor/attach_detach_conventions.rst +++ b/doc/source/contributor/attach_detach_conventions.rst @@ -34,7 +34,7 @@ There are three things that happen in the workflow for an attach or detach call. 2. Handle the connection operations that need to be done on the Volume - For Attach, this is the cinder.volume.api.initialize_connection method -- For Detach, the analogous calls is cinder.volume.api.terminate_connection +- For Detach, the analogous call is cinder.volume.api.terminate_connection 3. Finalize the status of the volume and release the resource diff --git a/doc/source/contributor/gerrit.rst b/doc/source/contributor/gerrit.rst index e5556548d80..db5ced02230 100644 --- a/doc/source/contributor/gerrit.rst +++ b/doc/source/contributor/gerrit.rst @@ -14,9 +14,9 @@ site is https://review.openstack.org Gerrit is a complete replacement for Github pull requests. `All Github pull requests to the Cinder repository will be ignored`. -See `Gerrit Workflow Quick Reference`_ for information about how to get -started using Gerrit. See `Development Workflow`_ for more detailed -documentation on how to work with Gerrit. +See `Quick Reference`_ for information on quick reference for developers. +See `Getting Started`_ for information on how to get started using Gerrit. +See `Development Workflow`_ for more detailed information on how to work with Gerrit. Targeting Milestones -------------------- @@ -88,5 +88,6 @@ to the submitter with a request for the addition of unit test. .. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html .. _Gerrit: https://review.openstack.org/#/q/project:openstack/cinder+status:open +.. _Quick Reference: https://docs.openstack.org/infra/manual/developers.html#quick-reference +.. _Getting Started: https://docs.openstack.org/infra/manual/developers.html#getting-started .. _Development Workflow: https://docs.openstack.org/infra/manual/developers.html#development-workflow -.. _Gerrit Workflow Quick Reference: https://docs.openstack.org/infra/manual/developers.html#development-workflow