From 40d50eccdef9cc1b42bb8e24e6b641b20213720d Mon Sep 17 00:00:00 2001 From: Lucio Seki Date: Mon, 18 Jun 2018 17:26:37 -0300 Subject: [PATCH] NetApp ONTAP: Remove NFS driver online volume extending support Cinder scheduler now checks backend capability online_extend_support before performing an online volume extend operation. This patch makes NetApp ONTAP NFS driver report to the scheduler that it doesn't support this feature, thus avoiding leaving a volume in error_extending state after an online extending attempt. Change-Id: Iafe3e68d6e9c20064a8825848b7b2d33ce7f4cff Depends-On: I2c31b5c171574074a8fc7ba86f94f983fc9658f7 Related-Bug: #1765182 --- .../unit/volume/drivers/netapp/dataontap/test_nfs_cmode.py | 1 + cinder/volume/drivers/netapp/dataontap/nfs_cmode.py | 1 + releasenotes/notes/bug-1765182-de132ba52167800b.yaml | 5 +++++ 3 files changed, 7 insertions(+) create mode 100644 releasenotes/notes/bug-1765182-de132ba52167800b.yaml diff --git a/cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_cmode.py b/cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_cmode.py index a93d2ad27df..9e998068b2e 100644 --- a/cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_cmode.py +++ b/cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_cmode.py @@ -246,6 +246,7 @@ class NetAppCmodeNfsDriverTestCase(test.TestCase): 'consistencygroup_support': True, 'consistent_group_snapshot_enabled': True, 'replication_enabled': False, + 'online_extend_support': False, }] expected[0].update({'QoS_support': cluster_credentials}) diff --git a/cinder/volume/drivers/netapp/dataontap/nfs_cmode.py b/cinder/volume/drivers/netapp/dataontap/nfs_cmode.py index 0163d5e4aba..deea4e0e855 100644 --- a/cinder/volume/drivers/netapp/dataontap/nfs_cmode.py +++ b/cinder/volume/drivers/netapp/dataontap/nfs_cmode.py @@ -274,6 +274,7 @@ class NetAppCmodeNfsDriver(nfs_base.NetAppNfsDriver, pool['consistencygroup_support'] = True pool['consistent_group_snapshot_enabled'] = True pool['multiattach'] = True + pool['online_extend_support'] = False # Add up-to-date capacity info nfs_share = ssc_vol_info['pool_name'] diff --git a/releasenotes/notes/bug-1765182-de132ba52167800b.yaml b/releasenotes/notes/bug-1765182-de132ba52167800b.yaml new file mode 100644 index 00000000000..6c2d4723b8b --- /dev/null +++ b/releasenotes/notes/bug-1765182-de132ba52167800b.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + NetApp ONTAP (bug 1765182): Make ONTAP NetApp NFS driver report to the + Cinder scheduler that it doesn't support online volume extending.