From 6e770fef421ada846b040fc8e3aaf85f8954e893 Mon Sep 17 00:00:00 2001
From: pooja jadhav <pooja.jadhav@nttdata.com>
Date: Thu, 30 Nov 2017 17:27:35 +0530
Subject: [PATCH] Discrepancy in api-ref and code for create group type API

'name' is mentioned as an optional parameter in api-ref doc for
POST /v3/{project_id}/group_types API but in the code if we don't
pass 'name' it returns BadRequest. Also in create and update API,
'is_public' parameter is not added in api-ref document.

This patch fixes this discrepancy by updating the api-ref according
to the code.

Change-Id: I34e53ac72cbda9d8264e48e50f5a84ca09b850bd
---
 api-ref/source/v3/group-types.inc | 2 ++
 api-ref/source/v3/parameters.yaml | 8 +++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/api-ref/source/v3/group-types.inc b/api-ref/source/v3/group-types.inc
index 6ac1808ebef..67ff6c0c9c4 100644
--- a/api-ref/source/v3/group-types.inc
+++ b/api-ref/source/v3/group-types.inc
@@ -29,6 +29,7 @@ Request
    - group_type: group_type
    - name: name_16
    - description: description_12
+   - is_public: is_public_2
 
 Request Example
 ---------------
@@ -183,6 +184,7 @@ Request
    - group_type: group_type
    - name: name_16
    - description: description_12
+   - is_public: is_public_2
    - group_specs: group_specs
 
 Request Example
diff --git a/api-ref/source/v3/parameters.yaml b/api-ref/source/v3/parameters.yaml
index e98278c2483..3fbae1a85d0 100644
--- a/api-ref/source/v3/parameters.yaml
+++ b/api-ref/source/v3/parameters.yaml
@@ -1396,6 +1396,12 @@ is_public_1:
   in: body
   required: false
   type: boolean
+is_public_2:
+  description:
+    Whether the group type is publicly visible.
+  in: body
+  required: false
+  type: boolean
 is_up:
   description: |
     Filter by up/down status.
@@ -1752,7 +1758,7 @@ name_16:
   description: |
     The group type name.
   in: body
-  required: false
+  required: true
   type: string
 name_17:
   description: |