From e337cdd407993f2b8beb0c679f00592595e85fa4 Mon Sep 17 00:00:00 2001 From: Tom Swanson Date: Thu, 1 Mar 2018 18:22:06 -0600 Subject: [PATCH] Dell EMC SC: Error Deleting Consistency Group Checking a return on something that doesn't return. Closes-Bug: #1752930 Change-Id: I5b6ae809814517657390b91878b917383eabd543 --- cinder/volume/drivers/dell_emc/sc/storagecenter_common.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cinder/volume/drivers/dell_emc/sc/storagecenter_common.py b/cinder/volume/drivers/dell_emc/sc/storagecenter_common.py index 36e53feb0e1..59705d211e4 100644 --- a/cinder/volume/drivers/dell_emc/sc/storagecenter_common.py +++ b/cinder/volume/drivers/dell_emc/sc/storagecenter_common.py @@ -876,8 +876,9 @@ class SCCommonDriver(driver.ManageableVD, for volume in volumes: status = fields.GroupStatus.ERROR try: - if self.delete_volume(volume): - status = fields.GroupStatus.DELETED + self.delete_volume(volume) + # We throw if that fails. + status = fields.GroupStatus.DELETED except (exception.VolumeBackendAPIException, exception.VolumeIsBusy): LOG.error('delete_group: error deleting volume %s',