From ed5012a22ee5013162850867ceb4ec707d38596e Mon Sep 17 00:00:00 2001
From: raghavendrat <raghavendra-uddhav.tilay@hpe.com>
Date: Thu, 18 May 2023 13:14:23 +0000
Subject: [PATCH] Nimble: Enable thin provisioning as default

Since the value of flag ``thin_provisioning_support`` is not set;
during create volume, by default thick volumes are created.

This patch changes default behaviour to create thin volumes;
which is in line with Nimble CLI behaviour.

Change-Id: I8845ed4ba029f6e3b7a3f0f99d438ce7228e4c42
---
 cinder/tests/unit/volume/drivers/hpe/test_nimble.py          | 1 +
 cinder/volume/drivers/hpe/nimble.py                          | 1 +
 .../nimble-thin-provision-by-default-c5ac66120b2361ef.yaml   | 5 +++++
 3 files changed, 7 insertions(+)
 create mode 100644 releasenotes/notes/nimble-thin-provision-by-default-c5ac66120b2361ef.yaml

diff --git a/cinder/tests/unit/volume/drivers/hpe/test_nimble.py b/cinder/tests/unit/volume/drivers/hpe/test_nimble.py
index c7cf3d67c4f..d85df2a0c04 100644
--- a/cinder/tests/unit/volume/drivers/hpe/test_nimble.py
+++ b/cinder/tests/unit/volume/drivers/hpe/test_nimble.py
@@ -1138,6 +1138,7 @@ class NimbleDriverVolumeTestCase(NimbleDriverBaseTestCase):
                                    'reserved_percentage': 0,
                                    'QoS_support': False,
                                    'multiattach': True,
+                                   'thin_provisioning_support': True,
                                    'consistent_group_snapshot_enabled': True}]}
         self.assertEqual(
             expected_res,
diff --git a/cinder/volume/drivers/hpe/nimble.py b/cinder/volume/drivers/hpe/nimble.py
index f061176c0e2..12239ccf93e 100644
--- a/cinder/volume/drivers/hpe/nimble.py
+++ b/cinder/volume/drivers/hpe/nimble.py
@@ -403,6 +403,7 @@ class NimbleBaseVolumeDriver(san.SanDriver):
                 reserved_percentage=0,
                 QoS_support=False,
                 multiattach=True,
+                thin_provisioning_support=True,
                 consistent_group_snapshot_enabled=True)
             self.group_stats['pools'] = [single_pool]
         return self.group_stats
diff --git a/releasenotes/notes/nimble-thin-provision-by-default-c5ac66120b2361ef.yaml b/releasenotes/notes/nimble-thin-provision-by-default-c5ac66120b2361ef.yaml
new file mode 100644
index 00000000000..1abe4690ac9
--- /dev/null
+++ b/releasenotes/notes/nimble-thin-provision-by-default-c5ac66120b2361ef.yaml
@@ -0,0 +1,5 @@
+---
+other:
+  - |
+    Nimble driver: Enable thin provisioning as default method while creating
+    volumes.