Got 100% test coverage for common

This is my first pass at getting 100% unit test coverage.

Updated the tests to be rspec3 compaable also.
falsey? really FALSEY?

Updated chef to 11.12.0

Change-Id: I667f631d9c98474f7fe730315626702bae38f573

spec/logging_spec.rb

@@ -27,6 +27,10 @@ describe 'openstack-common::logging' do
     describe 'logging.conf' do
       let(:file) { chef_run.template('/etc/openstack/logging.conf') }
 
+      it 'should create /etc/openstack/logging.conf' do
+        expect(chef_run).to create_template(file.name)
+      end
+
       it 'has proper owner' do
         expect(file.owner).to eq('root')
         expect(file.group).to eq('root')