openstack/cyborg
Code Issues Proposed changes

Merge "Fix delete attribute api bug"

Browse Source
This commit is contained in:
Zuul 2024-01-26 06:15:42 +00:00 committed by Gerrit Code Review
commit 31b8cc3c84
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cyborg/api/controllers/v2/attributes.py
View File

@ -163,4 +163,5 @@ class AttributesController(base.CyborgController,
""" """
LOG.info('[attributes] delete by uuid: %s.', uuid) LOG.info('[attributes] delete by uuid: %s.', uuid)
context = pecan.request.context context = pecan.request.context
objects.Attribute.destroy(context, uuid) api_obj_attribute = objects.Attribute.get(context, uuid)
api_obj_attribute.destroy(context)

3
cyborg/tests/unit/api/controllers/v2/test_attributes.py
View File

@ -114,8 +114,9 @@ class TestAttributes(v2_test.APITestV2):
for in_attribute, out_attribute in zip(attributes, out_attributes): for in_attribute, out_attribute in zip(attributes, out_attributes):
self._validate_attributes(in_attribute, out_attribute) self._validate_attributes(in_attribute, out_attribute)
@mock.patch('cyborg.objects.Attribute.get')
@mock.patch('cyborg.objects.Attribute.destroy') @mock.patch('cyborg.objects.Attribute.destroy')
def test_delete(self, mock_attribute_uuid): def test_delete(self, mock_attribute_delete, mock_attribute):
uuid = self.fake_attribute_objs[0]['uuid'] uuid = self.fake_attribute_objs[0]['uuid']
# Delete by UUID # Delete by UUID
url = self.ATTRIBUTE_URL + '/%s' % uuid url = self.ATTRIBUTE_URL + '/%s' % uuid