openstack/devstack
Code Issues Proposed changes

cinder_driver_certs.sh always passes driver

Browse Source 
In cinder_driver_certs.sh, the tests are run and output is
piped to "tee".  Currently, checking the exit code of this
command only checks that "tee" exited properly.  Using the
pipefail option for this script will ensure the entire
pipe succeeds before passing a driver.

Change-Id: I58311aa0e2c779467d39c4477c4ea39d14eda207
Closes-Bug: #1289129
This commit is contained in:
Ryan McNair 2014-03-07 05:31:56 +00:00
parent 31f7475baf
commit 0ebf2dfe62
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
driver_certs/cinder_driver_cert.sh
View File

@ -19,6 +19,8 @@
# #
# SCREEN_LOGDIR=/opt/stack/screen-logs # SCREEN_LOGDIR=/opt/stack/screen-logs
set -o pipefail
CERT_DIR=$(cd $(dirname "$0") && pwd) CERT_DIR=$(cd $(dirname "$0") && pwd)
TOP_DIR=$(cd $CERT_DIR/..; pwd) TOP_DIR=$(cd $CERT_DIR/..; pwd)