openstack/devstack
Code Issues Proposed changes

Update devstack exercises to call cinderclient

Browse Source 
Exercises use nova volume-* commands still.  This works fine,
however moving forward now that cinder is the default volume service
we should use the cinderclient explicitly for the applicable calls.

Attach/Detach are still novaclient commands, however the others
(create, delete, list, etc) should be cinderclient.

Change-Id: I336de1b69a32eee6c91655b0a5bf8541b243f2f0
This commit is contained in:
John Griffith 2012-11-05 13:59:49 -07:00
parent 308beccc24
commit 161e2807a9
2 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
exercises/boot_from_volume.sh
View File

@ -95,7 +95,7 @@ nova keypair-add $KEY_NAME > $KEY_FILE
chmod 600 $KEY_FILE chmod 600 $KEY_FILE
# Delete the old volume # Delete the old volume
nova volume-delete $VOL_NAME || true cinder delete $VOL_NAME || true
# Free every floating ips - setting FREE_ALL_FLOATING_IPS=True in localrc will make life easier for testers # Free every floating ips - setting FREE_ALL_FLOATING_IPS=True in localrc will make life easier for testers
if [ "$FREE_ALL_FLOATING_IPS" = "True" ]; then if [ "$FREE_ALL_FLOATING_IPS" = "True" ]; then
@ -112,15 +112,15 @@ if ! timeout $ASSOCIATE_TIMEOUT sh -c "while ! nova floating-ip-list | grep -q $
fi fi
# Create the bootable volume # Create the bootable volume
nova volume-create --display_name=$VOL_NAME --image-id $IMAGE 1 cinder create --display_name=$VOL_NAME --image-id $IMAGE 1
# Wait for volume to activate # Wait for volume to activate
if ! timeout $ACTIVE_TIMEOUT sh -c "while ! nova volume-list | grep $VOL_NAME | grep available; do sleep 1; done"; then if ! timeout $ACTIVE_TIMEOUT sh -c "while ! cinder list | grep $VOL_NAME | grep available; do sleep 1; done"; then
echo "Volume $VOL_NAME not created" echo "Volume $VOL_NAME not created"
exit 1 exit 1
fi fi
VOLUME_ID=`nova volume-list | grep $VOL_NAME | get_field 1` VOLUME_ID=`cinder list | grep $VOL_NAME | get_field 1`
# Boot instance from volume! This is done with the --block_device_mapping param. # Boot instance from volume! This is done with the --block_device_mapping param.
# The format of mapping is: # The format of mapping is:
@ -152,13 +152,13 @@ nova delete $VOL_INSTANCE_NAME || \
die "Failure deleting instance volume $VOL_INSTANCE_NAME" die "Failure deleting instance volume $VOL_INSTANCE_NAME"
# Wait till our volume is no longer in-use # Wait till our volume is no longer in-use
if ! timeout $ACTIVE_TIMEOUT sh -c "while ! nova volume-list | grep $VOL_NAME | grep available; do sleep 1; done"; then if ! timeout $ACTIVE_TIMEOUT sh -c "while ! cinder list | grep $VOL_NAME | grep available; do sleep 1; done"; then
echo "Volume $VOL_NAME not created" echo "Volume $VOL_NAME not created"
exit 1 exit 1
fi fi
# Delete the volume # Delete the volume
nova volume-delete $VOL_NAME || \ cinder delete $VOL_NAME || \
die "Failure deleting volume $VOLUME_NAME" die "Failure deleting volume $VOLUME_NAME"
# De-allocate the floating ip # De-allocate the floating ip

24
exercises/volumes.sh
View File

@ -2,7 +2,7 @@
# **volumes.sh** # **volumes.sh**
# Test nova volumes with the nova command from python-novaclient # Test cinder volumes with the cinder command from python-cinderclient
echo "*********************************************************************" echo "*********************************************************************"
echo "Begin DevStack Exercise: $0" echo "Begin DevStack Exercise: $0"
@ -131,28 +131,28 @@ ping_check "$PRIVATE_NETWORK_NAME" $IP $BOOT_TIMEOUT
VOL_NAME="myvol-$(openssl rand -hex 4)" VOL_NAME="myvol-$(openssl rand -hex 4)"
# Verify it doesn't exist # Verify it doesn't exist
if [[ -n "`nova volume-list | grep $VOL_NAME | head -1 | get_field 2`" ]]; then if [[ -n "`cinder list | grep $VOL_NAME | head -1 | get_field 2`" ]]; then
echo "Volume $VOL_NAME already exists" echo "Volume $VOL_NAME already exists"
exit 1 exit 1
fi fi
# Create a new volume # Create a new volume
nova volume-create --display_name $VOL_NAME --display_description "test volume: $VOL_NAME" 1 cinder create --display_name $VOL_NAME --display_description "test volume: $VOL_NAME" 1
if [[ $? != 0 ]]; then if [[ $? != 0 ]]; then
echo "Failure creating volume $VOL_NAME" echo "Failure creating volume $VOL_NAME"
exit 1 exit 1
fi fi
start_time=`date +%s` start_time=`date +%s`
if ! timeout $ACTIVE_TIMEOUT sh -c "while ! nova volume-list | grep $VOL_NAME | grep available; do sleep 1; done"; then if ! timeout $ACTIVE_TIMEOUT sh -c "while ! cinder list | grep $VOL_NAME | grep available; do sleep 1; done"; then
echo "Volume $VOL_NAME not created" echo "Volume $VOL_NAME not created"
exit 1 exit 1
fi fi
end_time=`date +%s` end_time=`date +%s`
echo "Completed volume-create in $((end_time - start_time)) seconds" echo "Completed cinder create in $((end_time - start_time)) seconds"
# Get volume ID # Get volume ID
VOL_ID=`nova volume-list | grep $VOL_NAME | head -1 | get_field 1` VOL_ID=`cinder list | grep $VOL_NAME | head -1 | get_field 1`
die_if_not_set VOL_ID "Failure retrieving volume ID for $VOL_NAME" die_if_not_set VOL_ID "Failure retrieving volume ID for $VOL_NAME"
# Attach to server # Attach to server
@ -160,14 +160,14 @@ DEVICE=/dev/vdb
start_time=`date +%s` start_time=`date +%s`
nova volume-attach $VM_UUID $VOL_ID $DEVICE || \ nova volume-attach $VM_UUID $VOL_ID $DEVICE || \
die "Failure attaching volume $VOL_NAME to $NAME" die "Failure attaching volume $VOL_NAME to $NAME"
if ! timeout $ACTIVE_TIMEOUT sh -c "while ! nova volume-list | grep $VOL_NAME | grep in-use; do sleep 1; done"; then if ! timeout $ACTIVE_TIMEOUT sh -c "while ! cinder list | grep $VOL_NAME | grep in-use; do sleep 1; done"; then
echo "Volume $VOL_NAME not attached to $NAME" echo "Volume $VOL_NAME not attached to $NAME"
exit 1 exit 1
fi fi
end_time=`date +%s` end_time=`date +%s`
echo "Completed volume-attach in $((end_time - start_time)) seconds" echo "Completed volume-attach in $((end_time - start_time)) seconds"
VOL_ATTACH=`nova volume-list | grep $VOL_NAME | head -1 | get_field -1` VOL_ATTACH=`cinder list | grep $VOL_NAME | head -1 | get_field -1`
die_if_not_set VOL_ATTACH "Failure retrieving $VOL_NAME status" die_if_not_set VOL_ATTACH "Failure retrieving $VOL_NAME status"
if [[ "$VOL_ATTACH" != $VM_UUID ]]; then if [[ "$VOL_ATTACH" != $VM_UUID ]]; then
echo "Volume not attached to correct instance" echo "Volume not attached to correct instance"
@ -177,7 +177,7 @@ fi
# Detach volume # Detach volume
start_time=`date +%s` start_time=`date +%s`
nova volume-detach $VM_UUID $VOL_ID || die "Failure detaching volume $VOL_NAME from $NAME" nova volume-detach $VM_UUID $VOL_ID || die "Failure detaching volume $VOL_NAME from $NAME"
if ! timeout $ACTIVE_TIMEOUT sh -c "while ! nova volume-list | grep $VOL_NAME | grep available; do sleep 1; done"; then if ! timeout $ACTIVE_TIMEOUT sh -c "while ! cinder list | grep $VOL_NAME | grep available; do sleep 1; done"; then
echo "Volume $VOL_NAME not detached from $NAME" echo "Volume $VOL_NAME not detached from $NAME"
exit 1 exit 1
fi fi
@ -186,13 +186,13 @@ echo "Completed volume-detach in $((end_time - start_time)) seconds"
# Delete volume # Delete volume
start_time=`date +%s` start_time=`date +%s`
nova volume-delete $VOL_ID || die "Failure deleting volume $VOL_NAME" cinder delete $VOL_ID || die "Failure deleting volume $VOL_NAME"
if ! timeout $ACTIVE_TIMEOUT sh -c "while ! nova volume-list | grep $VOL_NAME; do sleep 1; done"; then if ! timeout $ACTIVE_TIMEOUT sh -c "while ! cinder list | grep $VOL_NAME; do sleep 1; done"; then
echo "Volume $VOL_NAME not deleted" echo "Volume $VOL_NAME not deleted"
exit 1 exit 1
fi fi
end_time=`date +%s` end_time=`date +%s`
echo "Completed volume-delete in $((end_time - start_time)) seconds" echo "Completed cinder delete in $((end_time - start_time)) seconds"
# Shutdown the server # Shutdown the server
nova delete $VM_UUID || die "Failure deleting instance $NAME" nova delete $VM_UUID || die "Failure deleting instance $NAME"