openstack/devstack
Code Issues Proposed changes

Cloning requirements repository before pip install

Browse Source 
The commit 05aa3846a0 into devstack exposed a bug
where pip_install is called before the requirements repository is cloned. This
change ensures that the requirements repository exists before pip_install is
called.

Change-Id: I60b157fc98691764a69cf022852e7a95fc50cdd7
Closes-Bug: #1486304
This commit is contained in:
Shashank Hegde 2015-08-18 18:33:55 -07:00
parent c2eb60a751
commit 2d91fe8a6b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
stack.sh
View File

@ -683,6 +683,11 @@ save_stackenv $LINENO
# OpenStack uses a fair number of other projects. # OpenStack uses a fair number of other projects.
# Bring down global requirements before any use of pip_install. This is
# necessary to ensure that the constraints file is in place before we
# attempt to apply any constraints to pip installs.
git_clone $REQUIREMENTS_REPO $REQUIREMENTS_DIR $REQUIREMENTS_BRANCH
# Install package requirements # Install package requirements
# Source it so the entire environment is available # Source it so the entire environment is available
echo_summary "Installing package prerequisites" echo_summary "Installing package prerequisites"
@ -695,11 +700,6 @@ fi
TRACK_DEPENDS=${TRACK_DEPENDS:-False} TRACK_DEPENDS=${TRACK_DEPENDS:-False}
# Bring down global requirements before any use of pip_install. This is
# necessary to ensure that the constraints file is in place before we
# attempt to apply any constraints to pip installs.
git_clone $REQUIREMENTS_REPO $REQUIREMENTS_DIR $REQUIREMENTS_BRANCH
# Install Python packages into a virtualenv so that we can track them # Install Python packages into a virtualenv so that we can track them
if [[ $TRACK_DEPENDS = True ]]; then if [[ $TRACK_DEPENDS = True ]]; then
echo_summary "Installing Python packages into a virtualenv $DEST/.venv" echo_summary "Installing Python packages into a virtualenv $DEST/.venv"