openstack/devstack
Code Issues Proposed changes

Skip 'shocco' code when running tox

Browse Source 
when running tox in a devstack directory where you have previously run tox
-edocs the bashate testenv will fail as the shocco code doesn't match the
devstack style.

eg:
---
E003: Indent not multiple of 4: '           2>/dev/null ||'
 - /home/stack/projects/openstack/openstack-dev/devstack/shocco/shocco.sh : L352
<snip>
27 bashate error(s) found
---

Take the easy path and avoid running bashate in the shocco dir.

Change-Id: I5b0155332ec994afaffc5c5961902281864cff61
This commit is contained in:
Tony Breeds 2015-05-15 13:09:26 +10:00
parent 493d3b3aff
commit 31127a2a74
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
tox.ini
View File

@ -10,19 +10,20 @@ install_command = pip install {opts} {packages}
[testenv:bashate] [testenv:bashate]
deps = bashate deps = bashate
whitelist_externals = bash whitelist_externals = bash
commands = bash -c "find {toxinidir} \ commands = bash -c "find {toxinidir} \
-not \( -type d -name .?\* -prune \) \ # prune all 'dot' dirs -not \( -type d -name .?\* -prune \) \ # prune all 'dot' dirs
-not \( -type d -name doc -prune \) \ # skip documentation -not \( -type d -name doc -prune \) \ # skip documentation
-type f \ # only files -not \( -type d -name shocco -prune \) \ # skip shocco
-not -name \*~ \ # skip editors, readme, etc -type f \ # only files
-not -name \*.md \ -not -name \*~ \ # skip editors, readme, etc
\( \ -not -name \*.md \
-name \*.sh -or \ \( \
-name \*rc -or \ -name \*.sh -or \
-name functions\* -or \ -name \*rc -or \
-wholename \*/inc/\* -or \ # /inc files and -name functions\* -or \
-wholename \*/lib/\* \ # /lib files are shell, but -wholename \*/inc/\* -or \ # /inc files and
\) \ # have no extension -wholename \*/lib/\* \ # /lib files are shell, but
\) \ # have no extension
-print0 | xargs -0 bashate -v" -print0 | xargs -0 bashate -v"
[testenv:docs] [testenv:docs]