From 2ae8b09b6182d2927c684adb14c84800e460c2e2 Mon Sep 17 00:00:00 2001 From: Yi Zhao Date: Thu, 12 May 2016 12:11:24 +0800 Subject: [PATCH] Fix quoting in vercmp check for kernel version I352362cf59e492fa9f7725190f0243f2436ac347 switched this to vercmp, but using single-quote (') will mean that the kernel version isn't actually expanded for the comparision. I guess, like the original change, the fact it isn't working is hidden. Trusty seems to have 3.13 ... I can't imagine we support anything before this ... so I'd also be happy if someone with some OVS knowledge wants to just delete it. (This change was originally an alternative to I352362cf59e492fa9f7725190f0243f2436ac347 but got the quoting right) Change-Id: I9fa514885c20b1135fb0680cf61fc04628fbecbe Closes-Bug: #1580850 --- lib/neutron_plugins/ovs_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/neutron_plugins/ovs_base b/lib/neutron_plugins/ovs_base index 95f4663a52..ecf252f88b 100644 --- a/lib/neutron_plugins/ovs_base +++ b/lib/neutron_plugins/ovs_base @@ -54,7 +54,7 @@ function _neutron_ovs_base_install_ubuntu_dkms { local kernel_major_minor kernel_major_minor=`echo $kernel_version | cut -d. -f1-2` # From kernel 3.13 on, openvswitch-datapath-dkms is not needed - if vercmp '$kernel_major_minor' '<' '3.13'; then + if vercmp "$kernel_major_minor" "<" "3.13" ; then install_package "dkms openvswitch-datapath-dkms linux-headers-$kernel_version" fi }