openstack/devstack
Code Issues Proposed changes

Depreciated pip option PIP_DOWNLOAD_CACHE removal

Browse Source 
Fix warning:
DEPRECATION: --download-cache has been deprecated and will be removed in the
future. Pip now automatically uses and configures its cache.

1. Since version 6.0 (2014-12-22) pip has deprecated PIP_DOWNLOAD_CACHE
   and now automatically uses and configures its cache.
   Default new location is $HOME/.cache/pip.
2. pip gets upgraded to the latest version in tools/install_pip.sh
   but if pip version<6, exit with error: "Currently installed pip version
   ${pip_version} does not meet meet minimum requirements"

Change-Id: I8b203ffc6d9cf588462d0d65a9703a9941d8fa71
This commit is contained in:
Radoslaw Smigielski 2015-01-13 06:29:31 +00:00
parent fe2f986816
commit 6ce071b796
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
functions-common
View File

@ -26,7 +26,6 @@
# - ``ERROR_ON_CLONE`` # - ``ERROR_ON_CLONE``
# - ``FILES`` # - ``FILES``
# - ``OFFLINE`` # - ``OFFLINE``
# - ``PIP_DOWNLOAD_CACHE``
# - ``RECLONE`` # - ``RECLONE``
# - ``REQUIREMENTS_DIR`` # - ``REQUIREMENTS_DIR``
# - ``STACK_USER`` # - ``STACK_USER``
@ -1555,8 +1554,7 @@ function get_python_exec_prefix {
} }
# Wrapper for ``pip install`` to set cache and proxy environment variables # Wrapper for ``pip install`` to set cache and proxy environment variables
# Uses globals ``OFFLINE``, ``PIP_DOWNLOAD_CACHE``, # Uses globals ``OFFLINE``, ``TRACK_DEPENDS``, ``*_proxy``
# ``TRACK_DEPENDS``, ``*_proxy``
# pip_install package [package ...] # pip_install package [package ...]
function pip_install { function pip_install {
local xtrace=$(set +o | grep xtrace) local xtrace=$(set +o | grep xtrace)
@ -1581,8 +1579,15 @@ function pip_install {
local sudo_pip="sudo -H" local sudo_pip="sudo -H"
fi fi
local pip_version=$(python -c "import pip; \
print(pip.__version__.strip('.')[0])")
if (( pip_version<6 )); then
die $LINENO "Currently installed pip version ${pip_version} does not" \
"meet minimum requirements (>=6)."
fi
$xtrace $xtrace
$sudo_pip PIP_DOWNLOAD_CACHE=${PIP_DOWNLOAD_CACHE:-/var/cache/pip} \ $sudo_pip \
http_proxy=$http_proxy \ http_proxy=$http_proxy \
https_proxy=$https_proxy \ https_proxy=$https_proxy \
no_proxy=$no_proxy \ no_proxy=$no_proxy \
@ -1593,7 +1598,7 @@ function pip_install {
if [[ "$INSTALL_TESTONLY_PACKAGES" == "True" ]]; then if [[ "$INSTALL_TESTONLY_PACKAGES" == "True" ]]; then
local test_req="$@/test-requirements.txt" local test_req="$@/test-requirements.txt"
if [[ -e "$test_req" ]]; then if [[ -e "$test_req" ]]; then
$sudo_pip PIP_DOWNLOAD_CACHE=${PIP_DOWNLOAD_CACHE:-/var/cache/pip} \ $sudo_pip \
http_proxy=$http_proxy \ http_proxy=$http_proxy \
https_proxy=$https_proxy \ https_proxy=$https_proxy \
no_proxy=$no_proxy \ no_proxy=$no_proxy \