openstack/devstack
Code Issues Proposed changes

Remove output filter on rabbitmq install

Browse Source 
The original workaround was for an init script that grabbed stdout.
This was some time ago and I think it's safe to remove.

It can be a problem on Fedora; out-of-the-box some old F20 images can
have a broken dependency when rabbitmq installs.  With this in place,
all helpful output goes into the temp log file, but it is never shown
because the install_packages function exits the script.  Thus things
just stop and you have no idea why.

Change-Id: I2f5b934492a8c9d7b93e89fdcfa776bf15f25cb8
This commit is contained in:
Ian Wienand 2014-07-23 14:24:11 +10:00
parent f16ebbe085
commit 7ccf4e025a
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/rpc_backend
View File

@ -94,11 +94,7 @@ function cleanup_rpc_backend {
function install_rpc_backend { function install_rpc_backend {
if is_service_enabled rabbit; then if is_service_enabled rabbit; then
# Install rabbitmq-server # Install rabbitmq-server
# the temp file is necessary due to LP: #878600 install_package rabbitmq-server
tfile=$(mktemp)
install_package rabbitmq-server > "$tfile" 2>&1
cat "$tfile"
rm -f "$tfile"
elif is_service_enabled qpid; then elif is_service_enabled qpid; then
if is_fedora; then if is_fedora; then
install_package qpid-cpp-server install_package qpid-cpp-server