diff --git a/functions-common b/functions-common index 4a9db34119..486dcc5d59 100644 --- a/functions-common +++ b/functions-common @@ -1045,7 +1045,7 @@ function apt_get_update { # Uses globals ``OFFLINE``, ``*_proxy`` # apt_get operation package [package ...] function apt_get { - local xtrace + local xtrace result xtrace=$(set +o | grep xtrace) set +o xtrace @@ -1062,9 +1062,11 @@ function apt_get { http_proxy=${http_proxy:-} https_proxy=${https_proxy:-} \ no_proxy=${no_proxy:-} \ apt-get --option "Dpkg::Options::=--force-confold" --assume-yes "$@" + result=$? # stop the clock time_stop "apt-get" + return $result } function _parse_package_files { diff --git a/inc/python b/inc/python index c157604699..f4f65fd2e8 100644 --- a/inc/python +++ b/inc/python @@ -81,7 +81,7 @@ function get_python_versions_for_package { # ``PIP_UPGRADE``, ``TRACK_DEPENDS``, ``*_proxy``, # pip_install package [package ...] function pip_install { - local xtrace + local xtrace result xtrace=$(set +o | grep xtrace) set +o xtrace local upgrade="" @@ -155,10 +155,11 @@ function pip_install { PIP_FIND_LINKS=$PIP_FIND_LINKS \ $cmd_pip $upgrade \ $@ + result=$? # Also install test requirements local test_req="${!#}/test-requirements.txt" - if [[ -e "$test_req" ]]; then + if [[ $result == 0 ]] && [[ -e "$test_req" ]]; then echo "Installing test-requirements for $test_req" $sudo_pip \ http_proxy=${http_proxy:-} \ @@ -167,9 +168,11 @@ function pip_install { PIP_FIND_LINKS=$PIP_FIND_LINKS \ $cmd_pip $upgrade \ -r $test_req + result=$? fi time_stop "pip_install" + return $result } # get version of a package from global requirements file