openstack/devstack
Code Issues Proposed changes

Remove rejoin-stack.sh

Browse Source 
This command has never completely worked to restart DevStack.
It periodically prompts attempts to work around this brokenness
in ways that harm other functions.  Let's finally remove it.

Requiring a complete re-run of DevStack after a reboot has always
been intentional.

TODO: follow-up cleaning all of the screen hackage if this merges.

Change-Id: I2f61bb69cc110468a91dcaa4ee7653ede7048467
This commit is contained in:
Dean Troyer 2016-03-10 15:45:40 -06:00
parent 0aea130107
commit 9ba49cd826
2 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
functions-common
View File

@ -1643,7 +1643,7 @@ function service_check {
done done
if [ -n "$failures" ]; then if [ -n "$failures" ]; then
die $LINENO "More details about the above errors can be found with screen, with ./rejoin-stack.sh" die $LINENO "More details about the above errors can be found with screen"
fi fi
} }

25
rejoin-stack.sh
View File

@ -1,25 +0,0 @@
#! /usr/bin/env bash
# This script rejoins an existing screen, or re-creates a
# screen session from a previous run of stack.sh.
TOP_DIR=`dirname $0`
# Import common functions in case the localrc (loaded via stackrc)
# uses them.
source $TOP_DIR/functions
source $TOP_DIR/stackrc
SCREENRC=$TOP_DIR/$SCREEN_NAME-screenrc
# if screenrc exists, run screen
if [[ -e $SCREENRC ]]; then
if screen -ls | egrep -q "[0-9]+.${SCREEN_NAME}"; then
echo "Attaching to already started screen session.."
exec screen -r $SCREEN_NAME
fi
exec screen -c $SCREENRC
fi
echo "Couldn't find $SCREENRC file; have you run stack.sh yet?"
exit 1