openstack/devstack
Code Issues Proposed changes

chown stack/data/nova/networks to $STACK_USER

Browse Source 
$USER may be undefined (resulting in an error exit from stack.sh)
or may be the current $USER rather than the target $STACK_USER
(which may or may not be the same) which could lead to errors
later.

This change brings about consistency: the rest of stack.sh always
uses $STACK_USER.

This same problem may be present in lib/marconi.

Change-Id: Idff2bee88de4e1da11cd5765a03646caf3ede24f
This commit is contained in:
Chris Dent 2014-05-27 22:08:46 +01:00
parent 1e6e4289bc
commit a0ced4df00
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
stack.sh
View File

@ -1026,7 +1026,7 @@ if is_service_enabled n-net q-dhcp; then
if is_service_enabled n-net; then if is_service_enabled n-net; then
rm -rf ${NOVA_STATE_PATH}/networks rm -rf ${NOVA_STATE_PATH}/networks
sudo mkdir -p ${NOVA_STATE_PATH}/networks sudo mkdir -p ${NOVA_STATE_PATH}/networks
safe_chown -R ${USER} ${NOVA_STATE_PATH}/networks safe_chown -R ${STACK_USER} ${NOVA_STATE_PATH}/networks
fi fi
# Force IP forwarding on, just in case # Force IP forwarding on, just in case