openstack/devstack
Code Issues Proposed changes

Skip child process kills in stack.sh exit trap

Browse Source 
Logs are still being cut off in certain circumstances, almost certainly
because the awk process handling the output for verbose logging to a file
dies/is killed early.

Don't kill child processes in the EXIT trap function in this specific case.

Change-Id: I89600b61d59f87e93ff959710d0169e49d2c9845
This commit is contained in:
Dean Troyer 2014-03-21 13:00:32 -05:00
parent 116023f8e4
commit a3935fb0ad
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
stack.sh
View File

@ -595,7 +595,9 @@ trap exit_trap EXIT
function exit_trap {
local r=$?
jobs=$(jobs -p)
if [[ -n $jobs ]]; then
# Only do the kill when we're logging through a process substitution,
# which currently is only to verbose logfile
if [[ -n $jobs && -n "$LOGFILE" && "$VERBOSE" == "True" ]]; then
echo "exit_trap: cleaning up child processes"
kill 2>&1 $jobs
fi