From d3cfb82c65ae7f85b9d92e1245b1d81792a5641b Mon Sep 17 00:00:00 2001 From: Kashyap Chamarthy Date: Wed, 1 Apr 2015 11:30:57 +0200 Subject: [PATCH] functions-libvirt: Enable DEBUG_LIBVIRT config attribute by default Enabling it by default because: - This allows you to get the relevant logs right away when something in the libvirt code path fails, without having to submit another change and keep doing a 'recheck' to re-run the CI check/gate jobs until you hit the bug. - The libvirt log filters specified in the function 'configure_libvirt' are much more _selective_ and not a catch-all debug option where you end up with the unhelpful situation of having to find a "specific piece of hay in a haystack"[1]. FWIW, I always have it enabled in local test environments, and I don't see the resulting libvirtd.log growing beyond a couple of MB for three-four days of usage. [1] http://lists.openstack.org/pipermail/openstack-dev/2014-January/024414.html Change-Id: I5e0b35446075b419fe473e1db8d0bfedd7009741 --- lib/nova_plugins/functions-libvirt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/nova_plugins/functions-libvirt b/lib/nova_plugins/functions-libvirt index 05ef605b04..1a8e0e4e75 100644 --- a/lib/nova_plugins/functions-libvirt +++ b/lib/nova_plugins/functions-libvirt @@ -14,8 +14,11 @@ set +o xtrace # Defaults # -------- -# if we should turn on massive libvirt debugging -DEBUG_LIBVIRT=$(trueorfalse False DEBUG_LIBVIRT) +# Turn on selective debug log filters for libvirt. +# (NOTE: Enabling this by default, because the log filters enabled in +# 'configure_libvirt' function further below are _selective_ and not +# extremely verbose.) +DEBUG_LIBVIRT=$(trueorfalse True DEBUG_LIBVIRT) # Installs required distro-specific libvirt packages. function install_libvirt {