openstack/devstack
Code Issues Proposed changes

Fix EXTRA_OPTS handling

Browse Source 
In the conversion away from add_nova_opt the EXTRA_OPTS handling
inadvertently replaced all '=' chars in the value rather than
just the first.  Additional '=' is legal for an option value.

FWIW here is the setting that tripped it:
EXTRA_OPTS=default_log_levels=sqlalchemy=WARN,boto=WARN,eventlet.wsgi.server=WARN

Change-Id: I2deb139171250eb0ef5028bb924569cec31e1a4e
This commit is contained in:
Dean Troyer 2013-01-10 20:51:28 -06:00
parent 9f67bd692c
commit dff95122f7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/nova
View File

@ -432,8 +432,8 @@ function create_nova_conf() {
# Define extra nova conf flags by defining the array ``EXTRA_OPTS``. # Define extra nova conf flags by defining the array ``EXTRA_OPTS``.
# For Example: ``EXTRA_OPTS=(foo=true bar=2)`` # For Example: ``EXTRA_OPTS=(foo=true bar=2)``
for I in "${EXTRA_OPTS[@]}"; do for I in "${EXTRA_OPTS[@]}"; do
# Attempt to convert flags to options # Replace the first '=' with ' ' for iniset syntax
iniset $NOVA_CONF DEFAULT ${I//=/ } iniset $NOVA_CONF DEFAULT ${I/=/ }
done done
} }