openstack/devstack
Code Issues Proposed changes

Merge "clean up logging around run_process"

Browse Source
This commit is contained in:
Jenkins 2015-05-04 19:18:50 +00:00 committed by Gerrit Code Review
commit e210d26a19
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
functions-common
View File

@ -1137,6 +1137,10 @@ function zypper_install {
# the command. # the command.
# _run_process service "command-line" [group] # _run_process service "command-line" [group]
function _run_process { function _run_process {
# disable tracing through the exec redirects, it's just confusing in the logs.
xtrace=$(set +o | grep xtrace)
set +o xtrace
local service=$1 local service=$1
local command="$2" local command="$2"
local group=$3 local group=$3
@ -1160,6 +1164,9 @@ function _run_process {
export PYTHONUNBUFFERED=1 export PYTHONUNBUFFERED=1
fi fi
# reenable xtrace before we do *real* work
$xtrace
# Run under ``setsid`` to force the process to become a session and group leader. # Run under ``setsid`` to force the process to become a session and group leader.
# The pid saved can be used with pkill -g to get the entire process group. # The pid saved can be used with pkill -g to get the entire process group.
if [[ -n "$group" ]]; then if [[ -n "$group" ]]; then