607 Commits

Author SHA1 Message Date
Joe Gordon
bb1e07859c Don't install vim or locate by default
Devstack doesn't need vim or locate, if someone wants to use them, they
can just install them afterwards.

Change-Id: I00f27c20c86d89465e4aefc67ed645a309c09a03
2014-03-07 12:47:06 -08:00
Masayuki Igawa
46c688c1ae Fix pep8 errors
This commit fixes pep8 errors.

Change-Id: Ia1f1d61081a86b8a58251918392171cbc60f5ab8
2014-03-02 08:55:14 +09:00
Ian Wienand
aee18c749b Enforce function declaration format in bash8
Check that function calls look like ^function foo {$ in bash8, and fix
all existing failures of that check.  Add a note to HACKING.rst

Change-Id: Ic19eecb39e0b20273d1bcd551a42fe400d54e938
2014-02-28 07:59:03 +11:00
Jenkins
415893fadd Merge "Add end-of-file checks to bash8" 2014-02-27 04:36:59 +00:00
Jenkins
1c10bb3737 Merge "Move enablement of rhel6-optional repo earlier" 2014-02-26 19:04:11 +00:00
Jenkins
339ec17731 Merge "remove sysstat & pidstat" 2014-02-26 02:38:30 +00:00
Ian Wienand
3e37326a35 Move enablement of rhel6-optional repo earlier
Change 4f1fee6eae300a3384900df06ebc857e95854eb0 added the RHEL6
optional repo in fixup_stuff.sh, but it turns out that doesn't get run
until after the package prerequisites phase.  Move this into stack.sh
with the RDO repo setup.

Change-Id: Iae0df85fa94c6c1b6f497dd29fda90d03b903a41
2014-02-26 13:34:18 +11:00
Jenkins
e26b7bb415 Merge "Fix missing libffi-devel for python-glanceclient" 2014-02-25 23:32:36 +00:00
Ian Wienand
b8e250232e Add end-of-file checks to bash8
Add two end-of-file checks to bash8.  Firstly, alert if heredoc hasn't
finished.  Some heredocs were done like:

---
sudo bash -c "cat <<EOF > foo
...
EOF"
---

(A better way to do this is "cat <<EOF | sudo tee ..." as it retains
the usual heredoc layout in the code).

The trailing quote was throwing the matching in bash8 off and it kept
appending the next file as if it was still part of the heredoc.  To
avoid this, we check if we're still in a heredoc when we start a new
file; if so raise an error and reset the heredoc status fresh.  We
track the state of the previous file, line and lineno so we can give a
good error.

---
E012: heredoc did not end before EOF: 'cat <<EOF'
 - lib/trove: L221
---

This includes fixes for the existing problem heredocs.

A similar EOF check is to ensure the previous file ended with a
newline.

---
E004: file did not end with a newline: '$MY_XTRACE'
 - lib/neutron_plugins/embrane: L40
---

This requires only one fix

Change-Id: I5e547d87b3921fc7ce6588c28f074e5c9f489c1f
2014-02-26 09:31:15 +11:00
Sean Dague
78096b5073 remove sysstat & pidstat
dstat is far cleaner for getting results out of the environment,
and covers the bulk of our use cases for sysstat and pidstat with
a much better ui.

devstack is allowed to be opinionated, so become opinionated here.

Change-Id: I21ec96339dcd704098512fdafd896738f352962d
2014-02-25 10:30:31 -05:00
Jenkins
5d3e151aa3 Merge "Perform safety checks in create-stack-user.sh" 2014-02-25 02:51:45 +00:00
Jenkins
512da6e513 Merge "make bash8 take a -v flag" 2014-02-24 23:58:18 +00:00
Ian Wienand
4f1fee6eae Fix missing libffi-devel for python-glanceclient
python-glanceclient is failing to install on rhel6 with a dependency
chain from pip as

  cryptography>=0.2.1 (from pyOpenSSL>=0.11->python-glanceclient==0.12.0.56.gb8a850c)

cryptography requires libffi-devel to build.  I'm not sure what
changed, but remove it from "testonly" so it is always installed.

However, RHEL6 includes this in the optional repo, so we enable this
repo in the fixup script.

Change-Id: I9da0e91b75f41578861ee9685b8c7e91dd12dae7
2014-02-25 08:21:22 +11:00
Jim Rollenhagen
010959de40 Perform safety checks in create-stack-user.sh
This adds some safety checks to the stack user creation script.

This includes:
- Using set -o errexit to exit early on errors
- Make sure STACK_USER is set before doing anything with it

Change-Id: If027daddd03e32c5ba3c2ebb05ad5b27d2868b0a
2014-02-23 18:27:22 -08:00
Jenkins
e5bb257714 Merge "Remove unnecessary comment out lines" 2014-02-24 02:18:22 +00:00
Sean Dague
b93ee25b64 make bash8 take a -v flag
this ensures that we actually know we are processing all the files
we believe we are.

Change-Id: I8e99b5f9dc987c946586475f374f7040ca63a478
2014-02-23 20:41:07 -05:00
Jenkins
92558b8f5e Merge "Fix shocco errors" 2014-02-22 05:06:55 +00:00
Masayuki Igawa
1958c1eb5e Remove unnecessary comment out lines
This commit removes some comment-outed codes. If we want to use them, we
can get them from the git repository.

Change-Id: Ie438c43d332d0631750f0ad458653fc40e23faad
2014-02-20 14:35:44 +09:00
Jenkins
3ccd768db0 Merge "Rename Openstack to OpenStack" 2014-02-18 07:43:37 +00:00
Dean Troyer
d8864feae9 Fix shocco errors
Clean up comments to fix errors seen while processing with shocco

Change-Id: I0e97ad27613313f03e47c107051ea93b115d4744
2014-02-17 11:18:12 -06:00
Jenkins
20047053be Merge "Move install responsibilities to domU" 2014-02-15 02:17:20 +00:00
John Eckersberg
22dece0d96 Add Fedora support to install_docker.sh
On Fedora, just install the docker-io package as supplied in the
Fedora repository.

Change-Id: Iea74878d3e1c434863c188ea2253817384e56bf4
2014-02-13 16:26:28 -05:00
Jenkins
3fe7ad4709 Merge "Fix bug "Invalid OpenStack Nova credentials." on the gate" 2014-02-12 23:32:45 +00:00
Jenkins
98abadd44f Merge "Docker install script fails to install docker registry" 2014-02-12 23:28:16 +00:00
Sahid Orentino Ferdjaoui
1814e671d3 Fix bug "Invalid OpenStack Nova credentials." on the gate
During the process, when create_userrc.sh tries to creates
certificates and sourcable rc, it assumes that all users have
the same password.

Change-Id: Ifb57a43aad439ffe041e98465719a8a8eceae544
Closes-Bug: #1260723
2014-02-12 17:36:35 +01:00
tanlin
2b69f23625 Rename Openstack to OpenStack
Change-Id: I78ac040e926ef8040ee674b6fea3223a8ab4ae99
2014-02-12 17:52:17 +08:00
Jenkins
2276437fa0 Merge "remove build_tempest" 2014-02-11 20:30:49 +00:00
Jenkins
b4b9146de2 Merge "XenAPI: Fix new useage of trueorfalse" 2014-02-11 17:12:49 +00:00
Sean Dague
bc76f748eb remove build_tempest
we haven't actually used this script in about a year, in favor of
the actual in tree lib/tempest.

Change-Id: I9d78b395846ebe833a38ba50edae226040cd7f45
2014-02-10 21:11:04 -05:00
Daniel Kuffner
d1cd0c6648 Docker install script fails to install docker registry
The tools/docker/install_docker.sh script fails during the
installation/setup of the docker registry.
The problem is that the used environment variables are wrong.

REGISTRY_IMAGE > DOCKER_REGISTRY_IMAGE
REGISTRY_IMAGE_NAME > DOCKER_REGISTRY_IMAGE_NAME

Change-Id: I16f051abe5c426f295c69d518b49c1b9a7b4cc94
2014-02-08 12:43:23 +01:00
Shane Wang
5ed43bf82a Fix misspellings in devstack
Fix misspellings detected by:
 * pip install misspellings
 * git ls-files | grep -v locale | misspellings -f -

Change-Id: I19726438d15cd27b813504aac530e7e53c4def12
Closes-Bug: #1257295
2014-02-08 08:49:18 +08:00
Mate Lakat
d15c8a0824 Move install responsibilities to domU
As we are moving forward to test XenAPI in the gate, it is necessary to
move dom0 related modifications to be performed from domU. For this
purpose, a new user is created, and that user should be used to talk to
dom0 from domU. This change creates that user, makes it possible for
dom0 to log in to domU with that account, and configure that account to
be able to talk down to dom0.

Also move several steps to the nova xenserver plugin:
 - dom0 plugin installation
 - create kernels and images directory
 - install console rotate script
 - configure a cron to execute console rotate script

Configuration changes:
    A new configuration option, DOMZERO_USER has been created, that
    specifies a user account that is configured to be able to do
    passwordless ssh to dom0.

Change-Id: If9de0b297a67b7cdb5de78d8dd0e8b2ca578b601
2014-02-05 13:48:35 +00:00
Chmouel Boudjnah
86a8e97679 Add while/until to the for/do rule
Like 'for/do' check that the while/until operator are on
the same line with the do.

Fixes some pep8 error along the way.

Change-Id: I440afe60691263365bf35310bf4212d94f30c339
2014-02-05 07:52:54 +01:00
Sean Dague
16dd8b3ed9 introduce if/then & for/do rules
we mostly have a consistent style on if/then & for/do in devstack,
except when we don't. This attempts to build a set of rules to
enforce this.

Because there are times when lines are legitimately long, and there
is a continuation, this starts off ignoring if and for loops with
continuations. But for short versions, we should enforce this.

Changes to make devstack pass are included. The fact that the
cleanup patch was so small is pretty solid reason that this is
actually the style we've all agreed to.

Part of a git stash from hong kong that I finally cleaned up.

Change-Id: I6376d7afd59cc5ebba9ed69e5ee784a3d5934a10
2014-02-05 07:52:54 +01:00
Sean Dague
0656e12d68 add ability to ignore rules in bash8
Change-Id: Ia6472f4bb251bf3e9846e08e30b2f9ea30ea1c03
2014-02-04 05:32:04 +09:00
Jenkins
792490b68b Merge "Pull docker images from global registry" 2014-02-03 18:51:25 +00:00
Bob Ball
c643ebb26d XenAPI: Fix new useage of trueorfalse
* Ensure that Xen setup scripts will continue to function when unset
  variables are used in stackrc
* Ensure that the generic functions are sourced in all places that xenrc
  (which sources stackrc) is sourced.

Change-Id: I54eba20733c2e149621b74a1387f0bef14fca12e
2014-02-03 09:08:54 +00:00
Sean Dague
6114a518de fix sar reporting in the gate
the sar filter made an assumption of time display including an
AM/PM... which isn't true in all environments. Hence the blank
sysstat screen in the gate runs of late.

This fixes that, and displays the first line which includes header
version to make sure we are functioning.

Change-Id: I537e0bf2127efaf337c4792bc23d938145c8990d
2014-01-31 08:21:24 -05:00
Eric Windisch
2dac885e6c Pull docker images from global registry
The global docker registry is where images are
being built and uploaded. It's effectively docker's
version of, say, 'pip'. The static tarballs are
not only an extra maintenance burden as they're outside
the standard build and publishing process, but are presently
outside the scope of an open development / release
process as well.

While this process does cause some trouble with
network-independence for CI purposes, the fetching
is still done from install-docker.sh; Additionally,
this driver is not currently tested via the community CI effort.

Change-Id: I3ee6bfee9c273cd3aabe1e00a1d1a8856a466189
2014-01-31 01:39:03 -05:00
Sean Dague
d8416d7c1c allow for upgrade of the precise kernel
we are getting kernel crashes in the OpenStack gate, to test
getting around this we'd like devstack to be able to upgrade
the precise kernel to the latest lts backported kernel.

default to off

Change-Id: I5d47aa8d15b1b1c0386a13b65022f6b8108c5c49
2014-01-27 16:08:03 -05:00
Jenkins
fd52f0ea99 Merge "Updates for tools/info.sh" 2014-01-26 13:36:41 +00:00
Jenkins
448637e817 Merge "Workaround missing zip snapshot" 2014-01-25 18:38:11 +00:00
Jenkins
75f56df665 Merge "Fix xenapi functions' tests" 2014-01-25 18:37:56 +00:00
Sean Dague
a0a23311c3 updated sar options to collect more data
in order to have better data on the load state of the test nodes
we should track things beyond just cpu time. Add in load time,
process creation rates, and io rates during the tests.

also add a sar filter that makes it report on one line

reading sar input with multiple flags is somewhat problematic,
because it's tons of interspersed headers. So build something with
does a pivot filter to make it possible to get this all on one
line.

Change-Id: I8f085cedda65dfc37ad530eb97ba1fc5577314c3
2014-01-16 17:17:07 -05:00
Dean Troyer
d2bcbea5f9 Updates for tools/info.sh
* Handle local.conf localrc section
* remove blank lines
* rather than removing password lines, just remove the password itself to at
  least show which password vars have been set

Change-Id: Ieca9baaf03e53b23e336944ad0ed2581c9bee460
2014-01-13 14:26:13 -06:00
Sean Dague
2bb483d32e clean up ubuntu versions
oneiric is long dead, remove references to it whenever possible
(one more subtle issue in cinder should be a seperate patch). This
includes removing the oneiric only tool build_uec.sh.

also remove the bulk of references to quantal, which is 8 months
out of support. note: raring only has support for the rest of the
month.

Change-Id: Ib17502be7572af76dc95560615221b48b970a547
2014-01-11 19:13:47 -05:00
Mate Lakat
2781f3bfc3 Workaround missing zip snapshot
At the moment, xenserver installation depends on github snapshots.
Unfortunately, git.openstack.org does not have that capability. This
fix includes:

 - Exit with error code, if a download fails
 - create proper urls, even if they are using the git protocol
 - set git base to github - so we are able to do snapshots

Fixes bug: 1259905

Change-Id: I8d0cf8bf8abb16ee0a4b138a6719409c75e7a146
2014-01-07 10:20:37 +00:00
Mate Lakat
085abd8eb7 Fix xenapi functions' tests
The tests got outdated, this fix makes the tests pass again.

Change-Id: Iadddfbf34bf79ba455811645e766c2f3d0fcca84
2014-01-07 10:20:37 +00:00
Jenkins
161f1d70ee Merge "XenAPI: Fix bug with Xen ext4-using guests" 2014-01-02 18:08:19 +00:00
Jenkins
62c0cfa5d9 Merge "Mute false alarm when installing docker" 2014-01-01 13:28:24 +00:00