The '--no-wait' flag will not wait for ovs-vswitchd to reconfigure after
changes have been made to the database. This causes a race condition as
the bridge may or may not be up when 'ip addr flush dev $PUBLIC_BRIDGE' is
called. This commit removes the '--no-wait' flag which is safe as the
openvswitch services are already started earlier in stack.sh
Change-Id: I73ef1b731295d03b0f064c5f786196284c3e39ce
Closes-bug: #1328962
The files changed in this commit had incorrect bash syntax in that they were
assigning variables (=) instead of checking if they were equal (==). The
incorrect checks were preventing the configuration of VLANs with the Neutron
ML2 plugin.
Change-Id: I4b54bb5c69cc836c22900bd7a966197e9c616076
PLUMgrid plugin for Neutron supports to load dynamically a back-end driver.
This parameter has been added in the plugin configuration file.
Change-Id: I1698a8fa558841aeb94476bc8c7f103b21f2a2d3
Closes-bug: #1315466
Just like the beginning of every other release, remove the deprecated
config option aliases that were marked as deprecated in Icehouse.
Nova patch - https://review.openstack.org/#/c/88456/
Change-Id: Idd051c516002030e8e191c7b8d31f1ff408e1c7d
The various Neutron plugin files need to have unique variables for the
xtrace state as they are sometimes nested more than two levels deep
and MY_XTRACE is getting stomped. This gives each of the neutron_plugin
and neutron_thirdparty include files a unique XTRACE state variable.
I don't think this is a problem with any of the other plugin include
files (yet) so this just handles Neutron for now.
Change-Id: I7c272a48e7974edecaff5f431ff7443dd6622588
When the Cisco Nexus monolithic plugin is configured in the localrc,
stack.sh fails with the error message:
sed: can't read /etc/neutron/plugins/cisco/cisco_plugins.ini:
No such file or directory
This failure was introduced with the merge of change set 76992
(bug #1285884). Change set 76992 removed the copying of
Q_PLUGIN_EXTRA_CONF_FILES from the neutron project area to directories
under /etc/neutron. This copy from neutron to /etc is required by the
Cisco Nexus monolithic plugin, since this plugin follows the original
model for generating extra config files based on localrc settings:
- Copy default config file(s) from neutron project to /etc using
a relative path (relative to neutron and relative to /)
- Modify the copies of the config file(s) using localrc settings
- Add a --config-file command line setting for neutron server which
points to the modified config file(s) under /etc
The fix is to add the copying of the default versions of the extra
config files from neutron to /etc into the cisco devstack script.
Change-Id: Ifbae197ed591f7cccfd6d51eae2b21e31eb0a409
Closes-Bug: #1295411
Configures the Big Switch third-party plugin to
use neutron security groups instead of nova
security groups.
Change-Id: I6bc3046ff0e70b8288a7c3f3d6f975376adc081a
Implements: blueprint bigswitch-neutron-security
NCCLIENT_REPO value in lib/neutron_plugins/cisco is pointing to a repo
that does not exist. This fix corrects the url.
Closes-Bug #1286302
Change-Id: I42db0b3f7a4bbf5d1d053e3da8b4fbb67d47de94
This provides the support for the monolithic plugin
for IBM SDN-VE that is being added to Neutron here:
https://review.openstack.org/#/c/66453/
Implements: blueprint ibm-sdnve-plugin-support
Depends-On: I92619a95bca2ae0c37e7fdd39da30119b43d1ad6
DocImpact
Change-Id: I0958457355036fdab93156cd7fb4afd1a458918b
This patch supports configurations for an environment of the OpenFlow Agent mechanism driver
Set the following variables in a localrc to be ran this mechanism driver.
Q_ML2_PLUGIN_MECHANISM_DRIVERS=ofagent
Q_AGENT=ofagent
Implements: blueprint ryu-ml2-driver
Change-Id: I774da9a26f241487dfa4ec124b12f528704d860b
Check that function calls look like ^function foo {$ in bash8, and fix
all existing failures of that check. Add a note to HACKING.rst
Change-Id: Ic19eecb39e0b20273d1bcd551a42fe400d54e938
Add two end-of-file checks to bash8. Firstly, alert if heredoc hasn't
finished. Some heredocs were done like:
---
sudo bash -c "cat <<EOF > foo
...
EOF"
---
(A better way to do this is "cat <<EOF | sudo tee ..." as it retains
the usual heredoc layout in the code).
The trailing quote was throwing the matching in bash8 off and it kept
appending the next file as if it was still part of the heredoc. To
avoid this, we check if we're still in a heredoc when we start a new
file; if so raise an error and reset the heredoc status fresh. We
track the state of the previous file, line and lineno so we can give a
good error.
---
E012: heredoc did not end before EOF: 'cat <<EOF'
- lib/trove: L221
---
This includes fixes for the existing problem heredocs.
A similar EOF check is to ensure the previous file ended with a
newline.
---
E004: file did not end with a newline: '$MY_XTRACE'
- lib/neutron_plugins/embrane: L40
---
This requires only one fix
Change-Id: I5e547d87b3921fc7ce6588c28f074e5c9f489c1f
To be compatible with the Icehouse release of MidoNet, the
provider router configuration is removed from devstack since
it is no longer necessary to configure it.
Change-Id: I4be2d9bbf2c82fd375702cbb1d60c3277086134f
Implements: blueprint remove-provider-router-config-for-midonet
All other security group configs in Neutron are lower-case
and it should be consistent.
Change-Id: I683333c1e186446a69172446cca6d9b952673ed4
Closes-Bug: #1279862
we mostly have a consistent style on if/then & for/do in devstack,
except when we don't. This attempts to build a set of rules to
enforce this.
Because there are times when lines are legitimately long, and there
is a continuation, this starts off ignoring if and for loops with
continuations. But for short versions, we should enforce this.
Changes to make devstack pass are included. The fact that the
cleanup patch was so small is pretty solid reason that this is
actually the style we've all agreed to.
Part of a git stash from hong kong that I finally cleaned up.
Change-Id: I6376d7afd59cc5ebba9ed69e5ee784a3d5934a10
Implements blueprint embrane-plugin-support
This commit implements Embrane's Neutron plugin installation support
in Devstack.
This is an extension of the openvswitch installation module, which is
used by the main plugin, and enables configuration by localrc
Change-Id: Ia4824f8d2300bcdce170d226145bbce6088f1557
(Formerly known as Nicira NVP plugin).
Following Neutron change 79fbeb7ebebc0dfbe143aee96fbc250d1b9e7582,
this patch introduces the new naming scheme for Neutron VMware NSX
plugin configuration.
Related-blueprint: nvp-third-part-support (aka bp vmware-nsx-third-party)
Partial-implements blueprint: nicira-plugin-renaming
Change-Id: If7790887661507bfdec6d2b97c0f99609039aa73
When enabling neutron service (i.e. enable_service q-xxx), related code
unconditionally adds a necessary plugin class to Q_SERVICE_PLUGIN_CLASSES.
Which may cause duplication in Q_SERVICE_PLUGIN_CLASSES when
Q_SERVICE_PLUGIN_CLASSES is explicitly specified in localrc.
As a result, neutron server fails to start.
This patch introduces a utility function to add service class,
and check duplication.
Closes-Bug: #1261291
Change-Id: Id2880c7647babfccc3e8d9fc60dd93c4b3997ed9
Some of Neutron advanced services (LBaaS, VPNaaS, ....) creates
external processes and they should be stopped in unstack.
This commit defines neutron_<XaaS>_stop functions for all services
and implements the cleanup logics if necessary.
Also cleanup_neutron removes netns used by LBaaS haproxy.
Change-Id: Ied3a2c374ffcb6b59ecaf1027fb6e6083eded2ae
Three configuration parameters were missing for the PLUMgrid plugin.
In this patch all those three have been properly added.
Change-Id: If070aa5eb35678d0984470ebcd43fd99e08bcc8a
Closes-Bug: #1255808
Previously when running devstack with Neutron ML2 plugin,
an unnecessary file "ml2" is created in devstack directory.
It is because when the first argument is not defined the second
argument becomes the first one.
This change moves the first "options" argument of populate_ml2_config
to the last and checks the given options has a value before adding
them to a file.
Change-Id: I9ff40456798c42216d414d5f8d443e671ab7d497
Close-Bug: #1255853
In Havana, Neutron has now a Metering Agent which gets meters from
virtual routers.
This patchs aims to allow devstack using this new service.
Change-Id: I17ad83799d60384247b98cc8a93ac032f641c721
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
* Remove unused MIDONET specific settings from nova.conf
* Remove unused MIDONET specific settings from dhcp_agent.ini
* Move the interface_driver settings to the proper setting
function so that it can be used by lbaas_agent.ini as well.
Change-Id: Id686ff5f55db00bce42b8a2bd56e7655c73211fb
Closes-Bug: #1245401