devstack should run under -o errexit to ensure that we fail early
when something has gone wrong, otherwise determination of the root
failure location is often quite challenging.
this clears all the normal use cases for devstack, there could be
tests which now die early, which we're going to have to check for
later.
Change-Id: Ibd828c4f4fd95a60d3918d3d7ae90e10649479ab
* Force-flush log output so we don't lose log output in certain error cases.
* Slow down exit paths: add sleep to die(), wait until last moment to
kill child processes (including the awk log output filter)
Change-Id: I1620fd33b89b237d9c2bb6206f3de2c81719f676
we are xtrace happy, however that's just generating bulk in log
files that are mostly ignorable. For the basically bullet proof
functions we should not xtrace.
Change-Id: Iab4e6d270c1546e0db2a06395cefcdf7f7929c3c
During my CI testing of each devstack change I can often see git get
itself stuck and hang indefinitely. I'm not sure if it's transient
network issues, or issues at the remote end (seen with both github.com
and git.openstack.org) but it hits fairly frequently. Retrying the
command usually gets it going again. Searching for "git hanging" and
similar shows its not entirely uncommon...
This adds a watchdog timeout for remote git operations based on a new
environment variable GIT_TIMEOUT. It will retry 3 times before giving
up. The wrapper is applied to the main remote git calls.
Change-Id: I5b0114ca26b7ac2f25993264f761cba9ec8c09e1
This commit fixes comments about "System Functions".
* Add a missing comment about System Functions in the header
* Fix singular to plural like others
Change-Id: I3feb94cd11a6683ca80093574d60fdf7420e3af2
Backport changes made in Grenade's copy of functions since the last sync:
* d0654b9,i 4c7726e - get_release_name_from_branch()
* 7907766 - edits to install_package()
Change-Id: I0714c0b1072f1360c3c08fe24225e65e2a550fad
Move shared and non-DevStack-specific functions to `functions-common`. This is
a code move only with some updated comments. The functions are now
sorted alphabetically within function groups, eg. all git-related functions
are grouped together. The groups are listed at the top of the file.
'functions' sources 'functions-common' so no additional changes are required
for backward-compatability.
All functions shared with Grenade have also been moved.
functions-common was created from commit e0ed8ea038
Change-Id: I73bf7134fd6a60ec1ea44a5bfab08b0569b60ded
