240 Commits

Author SHA1 Message Date
Jenkins
5894db323f Merge "Move some comments of variables to right place" 2014-03-01 13:11:14 +00:00
Masayuki Igawa
d20f632a70 Move some comments of variables to right place
setup_develop*() in functions has been moved to functions-common. But
some comments about the variables are still left.
This commit moves it to the right place.

Change-Id: Ic360454f1ee72f51c9979d0468dee0913e9b32e4
2014-02-28 10:35:49 +09:00
Ian Wienand
aee18c749b Enforce function declaration format in bash8
Check that function calls look like ^function foo {$ in bash8, and fix
all existing failures of that check.  Add a note to HACKING.rst

Change-Id: Ic19eecb39e0b20273d1bcd551a42fe400d54e938
2014-02-28 07:59:03 +11:00
Dean Troyer
af616d9341 Move setup_develop() to common
It's in the wrong place for current Grenade

Change-Id: Ia670198332af5945a56d708cd83d9239df0c2287
2014-02-24 10:38:18 -06:00
Dean Troyer
d8864feae9 Fix shocco errors
Clean up comments to fix errors seen while processing with shocco

Change-Id: I0e97ad27613313f03e47c107051ea93b115d4744
2014-02-17 11:18:12 -06:00
Dean Troyer
dff49a242e Split functions
Move shared and non-DevStack-specific functions to `functions-common`.  This is
a code move only with some updated comments.  The functions are now
sorted alphabetically within function groups, eg. all git-related functions
are grouped together.  The groups are listed at the top of the file.

'functions' sources 'functions-common' so no additional changes are required
for backward-compatability.

All functions shared with Grenade have also been moved.

functions-common was created from commit e0ed8ea038299952826b27a16753775472f108d8

Change-Id: I73bf7134fd6a60ec1ea44a5bfab08b0569b60ded
2014-02-12 12:10:11 -06:00
Dean Troyer
e4fa721322 Begin is_service_enabled() cleanup
This converts the special cases in the is_service_enabled() function to call
individual functions declared by the projects.  This allows projects that
are not in the DevStack repo and called via the extras.d plugin to handle
an equivalent service alias.

* Ceilometer
* Cinder
* Glance
* Neutron
* Nova
* Swift

TODO: remove the tests from is_service_enabled() after a transition period

Patch Set 2: Rebased

Change-Id: Ic78be433f93a9dd5f46be548bdbd4c984e0da6e7
2014-02-07 10:06:21 -06:00
Arnaud Legendre
8dad4bde88 upload_image.sh to support streamOptimized disks
The current version of the script will use "preallocated" as the
disk type of a stream optimized disk. This needs to be fixed by
introspecting the createType of the vmdk file.

Closes-Bug: #1275993

Change-Id: I98594acecf26dd1164870f43890254a19ef23fe9
2014-02-03 18:17:01 -08:00
Jenkins
bfbcef0887 Merge "Make sure not to revert local changes." 2014-01-26 02:43:31 +00:00
Jenkins
58cc03629f Merge "upload_image.sh should parse filenames correctly" 2014-01-26 02:33:34 +00:00
Arnaud Legendre
b93cd64343 upload_image.sh should parse filenames correctly
The upload_image script gives the ability to the user to provide
specific metadata using the filename:
file-adapter_type;disk_type;network_type.vmdk
Currently, the regex expects each of these types to be populated.
This patch fixes this issue by making the regex more flexible and
accepts only one of these metadata to be populated.

Change-Id: If74cb06cc640864e7e91fd88943cdb37e05935d6
Closes-Bug: #1272126
2014-01-23 18:22:34 -08:00
Dean Troyer
579af5d678 Kill process groups in screen_stop()
Previously only the top child process was killed, killing the process
group also takes all of the child processes with it.

Closes-bug: 1271889
Change-Id: If1864cc4f1944f417ea3473d81d8b6e8e40030c2
2014-01-23 11:32:25 -06:00
IWAMOTO Toshihiro
0b8f6e0fbb Make sure not to revert local changes.
"git diff --quiet" has a bug ignoring local changes if there's a
unchanged file with a newer timestamp.  This patch works around
the bug.

Change-Id: I0ddc24e0f7af21287c43c1e04dd166ebff6f2dca
Closes-Bug: 1264422
2014-01-23 12:02:34 +09:00
Dean Troyer
9fc8792b0a Robustify service shutdown
* Save PID when using screen in screen_it()
* Add screen_stop()
* Call out service stop_*() in unstack.sh functions so screen_stop()
  can do its thing

Closes-bug: 1183449
Change-Id: Iac84231cfda960c4197de5b6e8ba6eb19225169a
2014-01-11 11:46:19 -06:00
Isaku Yamahata
6681a4fae9 bash8: fix bash8 warning
This patch removes the following bash8 warnings.

> /devstack/ $ ./run_tests.sh
> Running bash8...
> E003: Indent not multiple of 4: '             wget -c $image_url -O $FILES/$IMAGE_FNAME'
>  - functions: L1367
> E003: Indent not multiple of 4: '             if [[ $? -ne 0 ]]; then'
>  - functions: L1368
> E003: Indent not multiple of 4: '                 echo "Not found: $image_url"'
>  - functions: L1369
> E003: Indent not multiple of 4: '                 return'
>  - functions: L1370
> E003: Indent not multiple of 4: '             fi'
>  - functions: L1371
> E003: Indent not multiple of 4: '                                 `"should use a descriptor-data pair."'
>  - functions: L1423
> E003: Indent not multiple of 4: '                         `" Attempt to retrieve the *-flat.vmdk: $flat_url"'
>  - functions: L1438
> E003: Indent not multiple of 4: '                             `" Attempt to retrieve the descriptor *.vmdk: $descriptor_url"'
>  - functions: L1477
> E003: Indent not multiple of 4: '                         warn $LINENO "Descriptor not found $descriptor_url"'
>  - functions: L1492
> E003: Indent not multiple of 4: '                         descriptor_found=false'
>  - functions: L1493
> E003: Indent not multiple of 4: '                 fi'
>  - functions: L1501
> E003: Indent not multiple of 4: '             fi'
>  - functions: L1502
> E003: Indent not multiple of 4: '             #TODO(alegendre): handle streamOptimized once supported by the VMware driver.'
>  - functions: L1503
> E003: Indent not multiple of 4: '             vmdk_disktype="preallocated"'
>  - functions: L1504
> 14 bash8 error(s) found

Change-Id: Icf2cddf283192a50253ccfa697c2d32eec75b4ba
Closes-Bug: #1267716
2014-01-10 15:39:12 +09:00
Ian Wienand
be2ff9a745 Match RHEL Beta release strings
RHEL7 (in beta) has "Beta" after the release number and before the
code-name.  Add a number-match to the regex so everything between that
match and the codename in parenthesis is considered the release.

Change-Id: I992f20eedcefc6aeed6bd3ad57fc4cf20c8ef15d
2013-12-17 16:26:21 +11:00
Jenkins
6ef165cd7a Merge "Make rejoin-stack.sh resume file logging if enabled" 2013-12-17 00:40:02 +00:00
Andrea Frittoli
cd7d956fbc Handle the case of pipe char in value for iniset
iniset did not handle the case of "|" in the value
to be injected. Fix this by replacing | with \000 (NULL).

Fixes bug #1258050

Change-Id: I8882c2f3f177ebdfa0c66270dbbc7fd50f30b065
2013-12-12 12:24:55 +00:00
Dean Troyer
2ac8b3f3c2 Fix a couple of INI whitespace bugs
* iniset() bails if no section or option (attribute) is supplied
* merge_config_file() properly skips lines with only whitespace

* Also split the ini-tests into their own script

Bug 1257954

Change-Id: Ie31c5bd0df8dfed129fbcf1e37228aaf25e9305d
2013-12-09 10:30:02 -06:00
Darragh O'Reilly
bf36e8e4cf Make rejoin-stack.sh resume file logging if enabled
This patch ensures that screen will resume logging to files
after rejoin-stack.sh when SCREEN_LOGDIR is set.

Change-Id: I4c3eae0df7755b700dd8acf4bf14b7e383372ca3
Closes-bug: 1192568
2013-12-09 13:34:51 +00:00
Jenkins
b20d4d124e Merge "Generate glance image with SCSI bus type for ppc arch" 2013-12-05 18:02:04 +00:00
Rafael Folco
ab77587a37 Generate glance image with SCSI bus type for ppc arch
This patch fixes wrong assumptions for bus types of disk and cdrom
on ppc64. Qemu driver assumes IDE bus type for cdrom device, which
is not supported on ppc arch.
Adds capability to add --property key-value to the glance
image-create command.
Using double brackets for portability reasons.

Change-Id: I9f55fa0b6a894a93926e4f8c3d0ea410b5283f9c
2013-12-04 16:52:31 -02:00
Arnaud Legendre
90bcd2ff4d Attempt to retrieve the vmdk descriptor data-pair
VMDK formats such as monolithicFlat and vmfs require two files to be
fully consumable by the Nova drivers (a descriptor-data pair: *.vmdk and
*-flat.vmdk).
On the upload of the descriptor (*.vmdk), upload_image.sh should attempt to
retrieve the *-flat.vmdk. The same way, the descriptor should be
retrieved when a flat disk is uploaded.
On success, the upload script will be able to use the flat disk as the image
content and the relevant descriptor settings as the image metadata.

Change-Id: I9214754029c46dd60b9e7d606d84d8819a498a8d
Closes-Bug: #1252443
2013-12-03 17:57:24 -08:00
Jenkins
1fe3fc0457 Merge "Update vsphere image filename pattern" 2013-11-22 16:19:01 +00:00
Jenkins
202677ae30 Merge "Fix stackforge_libs installation step" 2013-11-22 09:58:08 +00:00
Jenkins
429b64e4a5 Merge "upload_image.sh should handle file URLs" 2013-11-22 03:02:08 +00:00
Jenkins
921c508027 Merge "Enable/disable ironic in tempest config" 2013-11-21 21:08:30 +00:00
Ryan Hsu
bfb3e5ec9c Update vsphere image filename pattern
The vsphere image filename pattern has been updated so that semi-
colons are used to delimit image properties rather than colons,
which are not permitted in Windows filesystems. To support back-
wards compatibility, colons can still be used.

Change-Id: I29a3ac03dcae294326dc8813a66512a79f705f81
Closes-Bug: #1250319
2013-11-19 20:54:23 -08:00
Doug Hellmann
aaac4eede9 Fix stackforge_libs installation step
When stackforge_libs is enabled, the WSME and Pecan libraries
are checked out from stackforge and installed from source instead of
pip. This change introduces a new function to perform the installation
without attempting to sync the global requirements list, since the
version of setup.py in the global requirements repository breaks the
dependencies for WSME (there is no ipaddr library in python 2, so we
need to install it, but under python 3 where it is part of the stdlib we
cannot include it in the requirements).

Fixes bug 1252488

Change-Id: I58357757ac67a919bf70178b76f65fa0a9e16242
2013-11-18 22:16:45 +00:00
Arnaud Legendre
3e439448b5 upload_image.sh should handle file URLs
upload_image.sh doesn't handle correctly file URLs: a file URL works only
if the file is already in the cache.
This patch provides support for file URLs of local files (RFC 1738)
http://tools.ietf.org/html/rfc1738

Change-Id: I107299c543cfa189e32848c32eefdbeb51a5e1f5
Closes-Bug: #1251752
2013-11-15 16:16:17 -08:00
Jenkins
80798bf56d Merge "Use vmdk descriptor to populate image properties" 2013-11-15 18:45:11 +00:00
Roman Prykhodchenko
d005959552 Enable/disable ironic in tempest config
In order to run tempest tests for Ironic in devstack
the availability of the Ironic service must be set in
the tempest config.

This patch adds a shortcut for Ironic services and sets
availability of Ironic in tempest config.

Change-Id: I206fc2ea13412ceb128f8bfe90c153348d6f2f3e
2013-11-14 09:58:53 +02:00
Arnaud Legendre
5ea53ee5f7 Use vmdk descriptor to populate image properties
image_upload.sh doesn't use the descriptor properties embedded inside
the vmdk file. This requires the user to manually change the filename of the
vmdk file to add the properties (disk type, storage adapter and network
adapter).
In case of a sparse monolithic sparse or stream-optimized sparse, these
properties are extracted from the descriptor.
The user can still override these values by modifying the filename.

Change-Id: I1734311c66efe60a1a30e3ea63cc2a9da9cdb5b4
Closes-Bug: #1247300
2013-11-12 15:45:53 -08:00
Jenkins
26e0a05a90 Merge "Fix horizon config under Apache 2.4" 2013-11-11 22:20:08 +00:00
Chris Buccella
610af8cfa7 Fix horizon config under Apache 2.4
Apache 2.4 now uses mod_authz_host for acces control. Horizon's
Apache config needs an update to allow access to its directory,
otherwise a 403 will be returned.
This change replaces a similar previous fixes done for Fedora 18
and Ubuntu 13.10, since this is an Apache version issue, not a
distro-specific one.

Change-Id: Iecc17600d8e1aae6a7b0929b1493d712c307616f
Closes-Bug: #1243075
2013-11-05 13:06:34 +00:00
DennyZhang
89d41ca239 Fix wrong variable comparision in functions
A whitespace is missing.
Closes-Bug: #1247273

Change-Id: I4bbed6077813c5d7522650baf2e78d9c44c1bba4
2013-11-01 15:41:23 -05:00
Jenkins
b7c11a0f98 Merge "Fix some Markdown formatting issues" 2013-10-31 14:19:15 +00:00
Jenkins
8e285072c9 Merge "Fix shocco errors and warnings" 2013-10-31 14:18:32 +00:00
Sean Dague
fd98edb469 create an UNDO_REQUIREMENTS variable
in the gate, we actually need to *not* roll back the requirements,
otherwise tempest can wedge the world because it runs under tox.

Make a variable that we can set to false in the gate to ensure that
we don't roll back the requirements changes.

Change-Id: I2b842ecc3f6e8b917dd721729640000bd7e7fb78
2013-10-24 15:09:47 -04:00
Jenkins
0c42f25043 Merge "Just reset the repo instead of trying to co files" 2013-10-24 16:48:54 +00:00
Adam Spiers
6a5aa7c6a2 Fix some Markdown formatting issues
Address miscellaneous issues with Markdown formatting in comments which
are consumed by shocco when generating the online documentation.

Change-Id: I953075cdbddbf1f119c6c7e35f039e2e54b79078
2013-10-24 17:38:19 +01:00
Adam Spiers
cb961597cc Fix shocco errors and warnings
A few Markdown-oriented issues were causing Docutils errors to
leak into the end-user docs on http://devstack.org

Change-Id: I51fa9698afb1bfb48596478d83bd1fdcd84ac52e
2013-10-24 15:43:05 +01:00
Jenkins
80c3ea52ed Merge "exit cleanup in functions" 2013-10-22 21:33:39 +00:00
Sean Dague
537d4025c5 whitespace cleanup on functions & lib/config
fix some of the bash8 issues found in functions and lib/config,
part of the long march towards fixing all the bash8 issues.

Change-Id: Ia131f64870acb0f9d196fe1a9a45d633abb6fc4d
2013-10-22 12:59:22 -04:00
Jenkins
92a864737e Merge "./stack.sh complain no /etc/nova/nova.conf" 2013-10-22 14:02:59 +00:00
Sean Dague
dc30bd3eb4 exit cleanup in functions
we should always use die instead of exit so that we know why we
failed.

Also remove instances where exit is called after die, as that is
a noop.

Change-Id: I8e08cce63d35c503c36ff1e09805f3db427d082d
2013-10-22 07:32:04 -04:00
DennyZhang
f43f3a59c2 ./stack.sh complain no /etc/nova/nova.conf
If nova.conf doesn't exist, mute error generated by grep.

Closes-Bug: #1239044

Change-Id: Ia497e2a9d8395cc11850fb16fd4075af9855b2a5
2013-10-20 09:49:52 -05:00
Chmouel Boudjnah
cbce1fa418 Just reset the repo instead of trying to co files
We can just reset the repo instead of trying to checkout specific files.
This fix external repos which doesn't not have requirements.txt or
test-requirements.txt.

Closes-Bug: 1231334
Change-Id: Iab898f5e8a422cc0cbfe44839c938f22c7525fd8
2013-10-17 11:43:48 +00:00
Jenkins
afcb049c7c Merge "Remove general assumption in get_packages()" 2013-10-16 21:13:51 +00:00
Jenkins
c5a1b05eba Merge "Add meta-config via local.conf" 2013-10-14 17:49:26 +00:00