18 Commits

Author SHA1 Message Date
Gary Kotton
51c681d605 Add support for deprecated configuration vars in Juno
Just like the beginning of every other release, remove the deprecated
config option aliases that were marked as deprecated in Icehouse.

Nova patch - https://review.openstack.org/#/c/88456/

Change-Id: Idd051c516002030e8e191c7b8d31f1ff408e1c7d
2014-04-26 01:45:27 -07:00
Joe Gordon
1cd8efc890 Don't use deprecated nova libvirt conf names
libvirt_cpu_mode was renamed to libvirt.cpu_mode
libvirt_type was renamed to libvirt.virt_type

This patch is needed before I346ee0248c03e60716bd7dc4a5ee4493610867cb can
land.

Change-Id: Ie8a39147ece3a3c86f4b146fa0af3641b1079319
2014-04-17 16:47:28 -07:00
Adam Gandelman
0f73ff2c51 Move libvirt install + setup to functions-libvirt
Moves installation and setup of libvirt to a common functions-libvirt,
which can be used by other drivers in the future that may require
cross-distro libvirt installation and config but are not using
VIRT_DRIVER=libvirt (ie, Ironic).

Change-Id: I4a9255c8b4bacd5acfde9b8061c9e537aeea592c
2014-03-13 15:03:55 -07:00
Sean Dague
dd304603e0 put libvirt debug behind a flag
only turn on the libvirt debugging if we really need it, which
we could control in the gate via devstack-gate.

Change-Id: I5e6d41d5333357608ab6a614610c060400f70a10
2014-03-11 16:38:57 -04:00
Sean Dague
13349080b1 put libvirt debug in the right place
libvirt debug setting was happening in a place where we weren't
actually resetting the daemon. Move it to into the hypervisor
plugin where we do.

Change-Id: Ia79b0ef50f6b8fb007a20ce5cb4e510a5e4600a5
2014-03-10 11:27:23 -04:00
Jenkins
dad6e4114d Merge "Enforce function declaration format in bash8" 2014-02-28 06:32:20 +00:00
Ian Wienand
aee18c749b Enforce function declaration format in bash8
Check that function calls look like ^function foo {$ in bash8, and fix
all existing failures of that check.  Add a note to HACKING.rst

Change-Id: Ic19eecb39e0b20273d1bcd551a42fe400d54e938
2014-02-28 07:59:03 +11:00
Attila Fazekas
a42650fb7e Fix libvirt polkit settings
After the https://review.openstack.org/#/c/75314 merged
the /etc/polkit-1/rules.d/50-libvirt-stack.rules files contains
subject.user == '"stack"' instead of
subject.user == 'stack'.

Change-Id: I09f252b2d0e53f012facb9f7eaa21c1e1bdf492b
2014-02-27 13:08:30 +01:00
Jenkins
415893fadd Merge "Add end-of-file checks to bash8" 2014-02-27 04:36:59 +00:00
Eric Windisch
201850120b Make python-guestfs NOPRIME & install for libvirt
The libguestfs dependency tree includes a number
of packages that we may not want or work everywhere, such as fuse.

Now python-(lib)guestfs will install from lib/nova_plugins/hypervisor-libvirt

Change-Id: I6c3a614010ee8d65813eec66a56680def622514c
2014-02-25 22:15:46 -05:00
Ian Wienand
b8e250232e Add end-of-file checks to bash8
Add two end-of-file checks to bash8.  Firstly, alert if heredoc hasn't
finished.  Some heredocs were done like:

---
sudo bash -c "cat <<EOF > foo
...
EOF"
---

(A better way to do this is "cat <<EOF | sudo tee ..." as it retains
the usual heredoc layout in the code).

The trailing quote was throwing the matching in bash8 off and it kept
appending the next file as if it was still part of the heredoc.  To
avoid this, we check if we're still in a heredoc when we start a new
file; if so raise an error and reset the heredoc status fresh.  We
track the state of the previous file, line and lineno so we can give a
good error.

---
E012: heredoc did not end before EOF: 'cat <<EOF'
 - lib/trove: L221
---

This includes fixes for the existing problem heredocs.

A similar EOF check is to ensure the previous file ended with a
newline.

---
E004: file did not end with a newline: '$MY_XTRACE'
 - lib/neutron_plugins/embrane: L40
---

This requires only one fix

Change-Id: I5e547d87b3921fc7ce6588c28f074e5c9f489c1f
2014-02-26 09:31:15 +11:00
Russell Bryant
5705db6913 Optionally enable file injection
There is a patch up for nova right now that disables file injection by default.
This is a corresponding devstack change that only sets file injection options if
it is enabled in the devstack config.  This is good to keep around so that we
can easily turn it on for testing.

The nova change is id Icff1304fc816acc843f8962727aef8bbbc7bbaa3.

Change-Id: I5015f2c351b1d680c205d7f9a5204febca490b91
2014-02-14 15:28:56 -05:00
Sean Dague
6bf1f1fb33 use ext4 for guest default ephemeral
this isn't upstream default because of compatibility questions
with really old host on providers. However there is no reason not
to do it in devstack.

Change-Id: I6438c0efb297cfa5d3dbb5f00701b24f01c39d14
2014-02-01 17:05:18 -05:00
Steven Dake
d5a5460888 Revert "Change the libvirtd log level to DEBUG"
Suggested by Daniel Berrange in this thread:
http://lists.openstack.org/pipermail/openstack-dev/2014-January/024407.html

This reverts commit 3bd85c9d6e257fc952cb3c6d0c09e199685bd5ed.

Change-Id: I370ba61cf8a00b51684cd504fed4ba4078d868be
2014-01-15 10:58:21 -07:00
Ken'ichi Ohmichi
3bd85c9d6e Change the libvirtd log level to DEBUG
Gate tests fail sometimes due to libvirt problems, but it is difficult
to investigate their reasons or workarounds because there is not any
log about libvirt.
This patch changes the log level of libvirtd to DEBUG for investigating
libvirt problems.

Change-Id: Ib6559ff978fa813d0332f2339d241dd3437196ee
Related-Bug: #1254872
2013-12-26 01:53:17 +09:00
Stephan Renatus
e578effb33 Make use of STACK_USER instead of relying on USER
Quite easily one ends up calling ./stack.sh in an environment that,
albeit being user "stack" (for example), doesn't quite meet the
expectations of devstack.  The errors that follow can be rather hard to
track down, as the dependency on `USER` is not mentioned.

To remedy this situation, this commit

- uses STACK_USER instead of USER and
- mentions that dependency in the script headers of lib/*

Change-Id: If4cdc39b922ea64b4c0893a0e695ec06349fccc5
2013-11-19 13:39:58 +01:00
Sean Dague
101b424842 fix whitespace in the rest of lib/*
this brings this in line with bash8 checker

Change-Id: Ib34a2292dd5bc259069457461041ec9cd4fd2957
2013-10-22 13:02:23 -04:00
Dean Troyer
8c032d1635 Convert remaining hypervisors to plugin model
Convert BareMetal, OpenVZ, PowerVM hnd libvirt ypervisor configurations
in Nova to the new plugin setup.

Change-Id: I47d744a2c9fdda0771f5b473ec3b26fb099f7439
2013-10-11 11:30:56 -05:00