openstack/diskimage-builder
Code Issues Proposed changes
2c10f65599
diskimage-builder/pylint.cfg

7 lines
96 B
INI
Raw Normal View History

Add pylint with indent check This is an initial creation of pylint with a basic indent checker. Small issues corrected. Job added to gate with Ib554a284e92583cc1d6a5c2219b3922852ca4c73 Change-Id: I7e24d8348db3aef79e1395d12692199a1f80161a Co-Authored-By: Andreas Florath <andreas@florath.net>
2017-05-29 16:05:35 +10:00
[MASTER]
persistent=no
[MESSAGES CONTROL]
disable=all
Refactor: use lazy logging As described in pep282 [1], the variable part of a log message should be passed in via parameter. In this case the parameters are evaluated only when they need to be. This patch fixes (unifies) this for DIB. A check using pylint was added that this kind of passing parameters to the logging subsystem is enforced in future. As a blueprint a similar (stripped-down) approach from cinder [2] was used. [1] https://www.python.org/dev/peps/pep-0282/ [2] https://github.com/openstack/cinder/blob/master/tox.ini Change-Id: I2d7bcc863e4e9583d82d204438b3c781ac99824e Signed-off-by: Andreas Florath <andreas@florath.net>
2017-05-28 05:19:05 +00:00
enable=bad-indentation, logging-not-lazy
Copy Permalink