Merge "elements: Drop executable bits from environment files"

This commit is contained in:
Jenkins 2016-12-06 03:18:33 +00:00 committed by Gerrit Code Review
commit b25044fe11
12 changed files with 5 additions and 1 deletions
bin
elements
centos/environment.d
debian-minimal/test-elements
stable-build-succeeds/environment.d
testing-build-succeeds/environment.d
debian/test-elements/build-succeeds/environment.d
devuser/environment.d
dynamic-login/init-scripts/upstart
gentoo/environment.d
manifests/environment.d
pip-cache/environment.d
ramdisk-base/extra-data.d/scripts/d
redhat-common/environment.d

@ -156,11 +156,15 @@ for i in $(find elements -type f \
fi
fi
# check that environment files don't "set -x"
# check that environment files don't "set -x" and they have no executable
# bits set
if [[ "$i" =~ (environment.d) ]]; then
if grep -q "set -x" $i; then
error "Environment file $i should not set tracing"
fi
if [[ -x $i ]]; then
error "Environment file $i should not be marked as executable"
fi
fi
# check that sudo calls in phases run outside the chroot look

0
elements/centos/environment.d/00-bootloader.bash Executable file → Normal file

0
elements/devuser/environment.d/50-devuser Executable file → Normal file

0
elements/gentoo/environment.d/00-gentoo-envars.bash Executable file → Normal file

0
elements/manifests/environment.d/14-manifests Executable file → Normal file

0
elements/pip-cache/environment.d/10-pip-cache Executable file → Normal file

0
elements/ramdisk-base/extra-data.d/scripts/d/init-func Executable file → Normal file

0
elements/redhat-common/environment.d/50-redhat-common Executable file → Normal file