openstack/election
Code Issues Proposed changes

Properly short-circuit OSF member lookup loop

Browse Source 
When iterating over Gerrit E-mail addresses to find a matching OSF
member Id, stop once one is found. That was the original intent, but
a continue was used instead of a break within the conditional
causing (perhaps very many) unnecessary additional queries against
the member lookup API.

Change-Id: I025170b726c2edd9dcb4996de99eb541b4e8abcf
This commit is contained in:
Jeremy Stanley 2018-08-23 19:59:43 +00:00
parent 6c9f07f7a2
commit 54d0a77b94
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack_election/owners.py
View File

@ -487,7 +487,7 @@ def main(options):
member = utils.lookup_member(email)
if member['data']:
owners[owner]['member'] = member['data'][0]['id']
continue
break
invite = [owners[owner].get('member', '0')]
invite.append(owners[owner]['name'].encode('utf-8'))
invite.append(owners[owner]['preferred'])