openstack/election
Code Issues Proposed changes

Detect values of None in utils.get_irc()

Browse Source 
The intent for the get_irc() function is to return an empty string
when no nick is found, but the API tends to provide a null (None)
value explicitly. When this happens, convert it to the empty string
too.

Change-Id: I9b62b1d722136246d1987a1a45ca771bdc02579c
This commit is contained in:
Jeremy Stanley 2019-09-05 20:22:39 +00:00
parent ebcd45e865
commit c48852e3bb
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstack_election/utils.py
View File

@ -178,6 +178,9 @@ def get_irc(member, filepath=None):
member_data = member.get('data', []) member_data = member.get('data', [])
if member_data: if member_data:
irc = member_data[0].get('irc', '') irc = member_data[0].get('irc', '')
# The API can return None for nonexistent nicks
if irc is None:
irc = ''
return irc return irc