openstack/glance
Code Issues Proposed changes

db: Replace sqlalchemy-migrate call with alembic equivalent

Browse Source 
The 'ocata_expand01_add_visibility' alembic migration was calling
'alter' on a table column, something that is only possible once you've
monkey patched sqlalchemy by importing the 'migrate' module. Resolve
this.

Change-Id: Ic71710aebafa38dceeead104b3e97fafa4bb4362
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This commit is contained in:
Stephen Finucane
2020-10-30 09:47:16 +00:00
parent a75aa3863a
commit 77676e833f
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
glance/db/sqlalchemy/alembic_migrations/versions/ocata_expand01_add_visibility.py
View File

@@ -19,10 +19,11 @@ Create Date: 2017-01-27 12:58:16.647499
""" """
from alembic import op from alembic import op
from sqlalchemy import Column, Enum, MetaData, Table from sqlalchemy import Column, Enum, MetaData
from glance.cmd import manage from glance.cmd import manage
from glance.db import migration from glance.db import migration
from glance.db.sqlalchemy.schema import Boolean
# revision identifiers, used by Alembic. # revision identifiers, used by Alembic.
revision = 'ocata_expand01' revision = 'ocata_expand01'
@@ -139,8 +140,10 @@ def _add_triggers(engine):
def _change_nullability_and_default_on_is_public(meta): def _change_nullability_and_default_on_is_public(meta):
# NOTE(hemanthm): we mark is_public as nullable so that when new versions # NOTE(hemanthm): we mark is_public as nullable so that when new versions
# add data only to be visibility column, is_public can be null. # add data only to be visibility column, is_public can be null.
images = Table('images', meta, autoload=True) with op.batch_alter_table('images') as batch_op:
images.c.is_public.alter(nullable=True, server_default=None) batch_op.alter_column(
'is_public', nullable=True, server_default=None,
existing_type=Boolean())
def upgrade(): def upgrade():