From c8ecd9321b1608371762acfabd3465a7a13348df Mon Sep 17 00:00:00 2001 From: Erno Kuvaja Date: Tue, 19 Jul 2016 00:32:57 +0200 Subject: [PATCH] Add LOG.warning to Disallowed minor changes Adds move to LOG.warning to disallowed minor changes page with explanation. Change-Id: Ib4ac1175005c8f41e65b56770e14d1a7817df7f0 --- doc/source/contributing/minor-code-changes.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/doc/source/contributing/minor-code-changes.rst b/doc/source/contributing/minor-code-changes.rst index c760edf6a3..be038d648d 100644 --- a/doc/source/contributing/minor-code-changes.rst +++ b/doc/source/contributing/minor-code-changes.rst @@ -31,3 +31,13 @@ like weakening changes. We're not saying that such changes can never be made, we're just saying that each change must be accompanied by an explanation of why the weaker test is adequate for what's being tested. + +LOG.warn to LOG.warning +----------------------- + +Consistently there are proposed changes that will change all {LOG,logging}. +warn to {LOG,logging}.warning across the codebase due to the deprecation in +Python 3. While the deprecation is real, Glance uses oslo_log that provides +alias warn and solves the issue in single place for all projects using it. +These changes are not accepted due to the huge amount of refactoring they +cause for no reason.