Prior to this patch, is_public filtering was applied in a
counterintuitive and potentially dangerous manner. In particular,
is_public=True would return images where is_public=False. Also, in a
variety of cases (that weren't exposed in the http api) users could list
private images that they do not own. This patch fixes those problems by
making is_public filtering work the same as any other filter and adding
separate visibility restrictions that always apply to list queries. To
preserve the existing behavior of the v1 api where admins by default do
not see all private images, admin contexts are deescalated to normal
contexts in certain situations.
With this change, pep8 ignores E712 because it is normal to use
"column == True" in sqlalchemy.
Fixes bug 1060481.
Fixes bug 1061331.
Change-Id: I086bd9273e337ebe184902b6f12bc8c9a7fc5867
Updated pep8 version requirement to 1.3.3.
Fixed E502 and E711 errors.
E711 is ignored because of sqlalchemy statements.
All ignores are to be removed in the next sequence of patches.
Change-Id: I27155166a60be14521d958e1cc7c06ebcc90f1fd
The test suite can be run now with pure nosetests + the openstack nose
plugin. There is no longer any need for the run_tests.py.
Change-Id: Iad89a2c1cc567ba10919a52166b3309edef20009
In order to ensure the glance-logcapture plugin is loaded dynamically,
we configure tox to drive tests with the run_tests.sh script intead of
calling nosetests directly.
This is intended as a temporary measure, pending promotion of the
glance-logcapture plugin to openstack-nose.
Change-Id: I556c751f4c2d31c1cbacd42d835ab436fb8f6988
My last commit message was right, the code was wrong. It's tox:jenkins.
Commands are invalid in tox: sections, so we'll get pip freeze run
another way.
Change-Id: Iafa21ff47cf5e3d8f57676be93e2fa6a0d0ab9b4
The tox documentation is wrong, it looks for [tox:jenkins] instead
of [tox:hudson]. Also, run "pip freeze" before running tests from
within the virtualenv so we have a record of all versions used
in each test run in Jenkins.
Change-Id: Id0f34247f4545268f21dacb860d2e0fe72677a11
Split requires in to pip-requires and test-requires.
Updated install_venv to know about test-requires.
Change-Id: I739f42c8676c40e2203cc0bc4aa9763ffac999a9
Allow for the running of arbitrary commands inside of a venv
so that we don't have to make tox envs for every blessed thing we want to
do.
Change-Id: Ia6f9e3cbeaef27ffe1e60b424c2a2d384e6bad0b
The tox.ini drives the current test suite in multiple virtual envs, so this
is a first step in trying to get multi-version testing.
Change-Id: I9c28ee11aa7bbe1b221a72e0ee8cc51d788f73c9
