This patch introduced double registering of the same
config option groups which fails glance-api start
if reserved stores are actually defined.
The code utilizing these config options has not been
merged which prevented testing to catch this.
Closes-Bug: #1844108
This reverts commit 4265e61bc84ce9bd085a95d8734647f4875af740.
Change-Id: Iaf338d29673e68a15d37fdda81add552e4175634
Since we know the names of the reserved stores, we can add them
to the config file to make it easier for operators to configure
these things.
Includes deprecation of the 'work_dir' and 'node_staging_uri'
options.
Change-Id: I992cf468f9ce156ba51b1dd025459939acd8dce0
This will allow oslopolicy-policy-generator to generate useful
information about Glance policies.
Change-Id: I3aeeeb67d19832ad72f0ab06c8adc0b018020c71
Closes-Bug: #1816647
One of the community goals for Stein is to implement a command-line
tool for operators that runs programmable checks that might impact
upgradability.
This commit lays down the basic structure for the upgrade checks and
ties it up to `glance-status` command.
Change-Id: I7fcf5235a76d15dbcb2c49255bc26c2b586cd71c
Story: 2003657
Task: 26135
openstack-dev was decomissioned this night in https://review.openstack.org/621258
Update openstack-dev to openstack-discuss
Change-Id: I6b5a3489c3e09bc1413dbac174310339151df05b
https://review.openstack.org/527425 removed etc/rootwrap.conf, but
it did not remove its entry on setup.cfg. Thus, any attempt to do
"python setup.py install" will fail.
Change-Id: I041551fb6efb8fd52ff1eaa55f6b4af6738c4ded
In Python 3.7, "async" is a keyword. To prevent it from
conflicting, rename the async package to async_.
Change-Id: I1eaf87eedb86679d9ca9323aac05f0770c33efea
Closes-Bug: #1781617
At install_data hook, it tries to glance-image-import.conf which
does not exist. Since it is an optional file, let's not install it
by default.
Change-Id: I8a5122355da43c592b0cbad0eb7921875e0a5e99
This change adds 'web-download' Image Import method.
Changes discovery call returning actual enabled methods rather than
hardcoded value.
Change-Id: I3960d07cfa4e1be391f7a164147611724788d83e
Implements the spec Inject metadata properties automatically
to non-admin images
This commit adds new task '_InjectImageMetadata' to inject
the metadata properties automatically to non-admin images
at the time of creation of images using newly introduce
'image-import' api in v2.
DocImpact
Implements: I6a7ed31d5fae677cbbc9a6f6053f79d3e9326561
Change-Id: I98be97c42f23b60a72d520aad5f6078a96372c59
This change adds hooks for pulling in plugins for
Interoperable Image Import taksflow. Boilerplate Noop
plugin is provided as an example and for testing.
Change-Id: If14c7dc4f38360006f9cb350fbba54fa2f33be61
In order to make it simpler to use the default
configuration files when deploying services
from source, the files are added to pbr's
data_files section so that the files are
included in the built wheels and therefore
deployed with the code. Packaging and deployment
tools can then more easily use the default files
if they wish to.
This pattern is already established with similar
files for neutron and the glance metadefs as has
been mentioned in the related bug report.
Change-Id: Ie0eb7f16bc975de0db80a2144fd8db9e09f6317f
Closes-Bug: #1718356
The immediate cause was that the api_image_import flow was not
listed in the entrypoints in setup.cfg, so stevedore couldn't find
it. After the entrypoint was added, the task was going to failure
because it couldn't find the image_id. So this patch has the
import controller add the image_id to the task_input dict. Next
the flows were having trouble finding the image_id, so I just
passed it to them. There's probably a more elegant way to have
taskflow handle this, so this patch could use a refactoring. On
the plus side, the interoperable image import process does appear
to work with this patch.
NOTE: if you want to test this in devstack, use the stable/ocata
devstack but with the master branch of glance. The tasks engine
doesn't appear to be running under the Pike devstack configuration.
(Use defect 1712463 if you have an idea what might be the problem.)
Change-Id: Ic68c17f4cb671eb664e2de331787b55fe9878a27
Closes-bug: #1712462
A recent release of pbr explicitly requires stating which builders are
requested, rather than defaulting to html and man. This has resulted in
man pages not being built. Correct this oversight, along with a few
issues that have been introduced to 'doc/source/conf.py' since. It is
also necessary to remove a couple of plugins as there seems to be
another pbr bug under the hood. Fortunately none of these are used so
it's all good.
Change-Id: I22fd4d113704949dbf7704f50fa1d08fa10f11b6
Use autodoc_index_modules instead of autodoc_tree_index_modules so only
one copy of the API docs are generated.
Exclude the tests subpackage because it's not part of the Glance Python
API.
Exclude the glance.db.sqlalchemy subpackage to avoid issues caused when
parts of it cannot be imported during the doc build because they rely on
alembic setting up values that are not configured for a simple import.
Change-Id: I127b812bc879fc39533b39df1785d93835142430
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This change moves existing files, updates a few of the cross-references
and paths, and fixes some formatting. It is not meant to be the final
word on how the main page looks or how the other files are organized,
but it gets everything roughly into shape. If the glance team wants to
make changes, please do those as follow-up patches
This change depends on the spec and on a feature of pbr that allows us
to move where the auto-generated class reference documentation ends up
in the tree.
Depends-On: Ia750cb049c0f53a234ea70ce1f2bbbb7a2aa9454
Depends-On: I2bd5652bb59cbd9c939931ba2e7db1b37d2b30bb
Change-Id: I9dde267793a5913acb5b1ec028cfb66bc5189783
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit adds a pbr entrypoint for the wsgi script file. This enables
deploying glance as a proper wsgi application instead of a standalone
service.
Change-Id: I089a22a4be4227a551c32442dba27c426f54c87d
I3026ca6287a65ab5287bf3843f2a9d756ce15139 removed Glare from the Glance
codebase, but left some lines in setup.cfg.
This patch removes the remnant of the references in the code tree.
Co-Authored-By: Javier Pena <jpena@redhat.com>
Co-Authored-By: Nikhil Komawar <nik.komawar@gmail.com>
Depends-on: I02bfe805c419fcc49ac43b66f4f7b1a0d1d54755
Change-Id: Ia3652eb0dede3614cc4ea880f8ddc06c95740797
warnerrors used to show the errors in output when the docs generate
but now it looks like when this patch lands [0] it will cause the gate
to fail. I will push up a patch to fix all the docs problems but we
should revert this so we don't have a day when the gate is broken.
[0] https://review.openstack.org/#/c/229951
Change-Id: Ica33f1fd5acdc17a115d7a3bd81f8f4d79c1a809
No config generator hooks should ever be registered with a name that
belongs to another project. In this case, using oslo.middleware.cors
means that *every other project* that loads the middleware gets this
application's defaults when the generator is run on a system with
everything installed (such as a dev box with devstack). Use the name
of the app instead, to ensure that the defaults are only set when this
app's sample config and documentation are being generated.
Change-Id: I6a8c7d44b9db9325003ff2fdb667b0ced7739e96
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
It looks like in the docs config.py there
needs to be some modifications so the module
docs can be generated through sphinx
Change-Id: I41a2d62a2300100d9fb412698360bb1238cf7406
Closes-Bug: #1552830
The default values needed for glance's implementation of cors
middleware have been moved from paste.ini into the configuration
hooks provided by oslo.config. Furthermore, these values have been
added to glance's default configuration parsing. This ensures
that if a value remains unset in glance-api.conf, it will be set to use
sane defaults, and that an operator modifying the configuration
file will be presented with a default set of necessary sane headers.
Change-Id: I3c9d267b6224d6c7e5cc2c41cb51fb7e363c4955
Closes-Bug: 1551836
Run security linter bandit as part of pep8. Pep8 is the usual linter
target and thus let's use it there instead of starting another node for
this short-running job.
Move bandit requirement to test-requirements.
Disable temporarily some tests in bandit.yaml since they advocate using
defusedxml which is not in global-requirements.txt and thus cannot be
used inside bandit (bug#1550161).
Change-Id: Ie3c9f4ee6e061ea090fa882f4f029f2761706951
Supports import of OVA/OVF package to Glance by adding a new task to
the existing Glance import workflow. Automatically extracts single disk
image from OVA tarball and saves it to the Glance image store. It also
parses the included OVF file for interested metadata. Extracted
metadata is included as uploaded image's properties.
To kick off this flow, specify 'ova' as 'container_format' in the
task-create request. Specify interested metadata in the
'ovf-metadata.json' conf file, generally located at /etc/glance. Any
other additional metadata found in the OVF file will be ignored.
Currently this is an admin only feature and only supports upload of
single disk images. Also currently we will only be supporting extracting
properties from CIM_ProcessorAllocationSettingData.
Co-Authored-By: Jakub Jasek <jakubx.jasek@intel.com>
Co-Authored-By: Deepti Ramakrishna <deepti.ramakrishna@intel.com>
Change-Id: I4c9c9566895c2426f26d2750c8e2a23b39468fb1
Implements: blueprint ovf-lite
EXPERIMENTAL Glance v3 API has been removed in favor of standalone API
(EXPERIMENTAL Artifacts API of v0.1).
This patch introduces a new process entry point to run on a different
port (9494 by default), with its own configuration file and a paste
config.
A controller stub for old /v3 api remains in the glnace.api package for
the compatibility with existing paste configuration which may reference
it. This stub returns a 301 redirects to glare endpoint if it is present
or 410 errors otherwise.
To reuse the existing version_negotiation middleware some refactoring
has been made.
Implements blueprint: move-v3-to-glare
Change-Id: I5b7bd4cdcc5f2a40fc4a5f74bcc422fd700c4fb0
Add packages line which is normal for setup.cfg. The new infra
translations scripts need this to figure out the module used.
Change-Id: I9687fba8e956eaf28673a72f0e1a10da3b3b0b8f
Story: 2000452
Per [1] we now want to use the git repository for knowing the version
instead of just trying to modify the setup.cfg file.
[1] http://lists.openstack.org/pipermail/openstack-dev/2015-November/080692.html
Depends-On: Id86498f9a65897c0e002ded3df745a8076090e96
Change-Id: I880615c1cafefaebb7dc3084f466875de9b7fd48
Set up automated bandit checks using tox. These tests are intended to be
eventually suitable as automated gate tests.
Currently, several tests are disabled (and labeled with a TODO to enable
them). A future commit for each test will enable that test, fix all
associated false positives, and fix all associated real positives.
Change-Id: I290992be027eac180b3a0dfcf601465079c2915c
Partial-bug: 1511862
We depend on glance_store in requirements.txt so there is no reason to
also depend on it as an extra.
Change-Id: I8c91a7c21247fb52cb777d3ab94cd1c7eee22adc
Bump preversion to mark the start of the Mitaka development branch.
The liberty release branch will be cut from the previous commit.
Change-Id: I25c9c2056ff490f28e0f898b30c4127deacb7f7a
Backend store-specific requirements are not hard requirements, since
the choice of backend store is up to the operator. The
python-swiftclient and oslo.vmware modules are herein moved out of
requirements.txt and instead listed as optional requirements using
the extras functionality in setup.cfg.
Removed unnecessary import of swift backend in db migration, to allow
python-swiftclient to move out of hard requirements.
Cleaned up other requirements that are no longer used.
Change-Id: I9edbf8a614b5caaf38b4c59bd864b7baa55bf36b
Depends-On: I94d75e3d52c9e3e9f7a741a079d25b1bdff29b27
Closes-Bug: #1475737