Add a new import method called glance-download
that implements a glance to glance download in
a multi-region cloud with a federated Keystone.
This method will copy the image data and
selected metadata to the target glance, checking
that the downloaded size match the "size" image
attribute in the source glance.
Implements: blueprint glance-download-import
Co-Authored-By: Victor Coutellier <victor.coutellier@gmail.com>
Change-Id: Ic51c5fd87caf04d38aeaf758ad2d0e2f28098e4d
In Zed cycle, we have dropped the python 3.6/3.7[1] testing
and its support. Moving the py36 job to py38 based as well as
updating the python classifier also to reflect the same.
openstack-tox-functional-py36-fips job is left which can be moved
to py38|py39 based once that job is defined in openatck-zuul-jobs
repo.
openstack-tox-functional-py36-fips job will be migrated to py38 or py39
in followup patch as that need openstack-zuul-config changes too.
[1] https://governance.openstack.org/tc/reference/runtimes/zed.html
Change-Id: Id0813d9dc553dd424732079039349b42f6f3201b
Python 2 support was removed during Ussuri cycle. This change adds
the classifier to clearly state that only Python 3 is supported.
Change-Id: Ib244469e09e396ea897d1778bb1bad15cebf1f10
The author of change I08c014e10c3fc54046930ea8be2b13775428e51b fat
fingered the replacement of 'python-requires' with 'python_requires'
resulting in the following warning:
UserWarning: Usage of dash-separated 'python-r_quires' will not be
supported in future versions. Please use the underscore name
'python_r_quires' instead
Not sure how setuptools was still identifying but resolve it
nonetheless.
Related-Bug: #1939716
Change-Id: I293919d6dc93bf221eae9109fd4a658d332bdca8
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This doesn't actually do anything, and hasn't since we merged change
I77921366a05ba6f9841143af89c1f4059d8454c6 way back in Ocata. Drop it.
Change-Id: I623b2ffb8bdd72525241835b5d1164c275f9fe73
Implements: blueprint remove-sqlalchemy-migrate
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Resolves warnings like the following:
UserWarning: Usage of dash-separated 'description-file' will not be
supported in future versions. Please use the underscore name
'description_file' instead
Change-Id: I08c014e10c3fc54046930ea8be2b13775428e51b
As per the community goal of migrating the policy file
the format from JSON to YAML[1], we need to do two things:
1. Change the default value of '[oslo_policy] policy_file''
config option from 'policy.json' to 'policy.yaml' with
upgrade checks.
2. Deprecate the JSON formatted policy file on the project side
via warning in doc and releasenotes.
Also convert the ./glance/tests/etc/policy.json to policy.yaml
file. Replace policy.json to policy.yaml ref from doc and tests.
[1]https://governance.openstack.org/tc/goals/selected/wallaby/migrate-policy-format-from-json-to-yaml.html
Depends-On: https://review.opendev.org/c/openstack/nova/+/773192
Change-Id: I17d0374dd4223688e5f95253802a4ae87377953a
This patch removes majority of the registry and it's related
endpoints and config options that has been deprecated for
removal in various releases.
Change-Id: I75014bd50bf382efebe56bd89c20ffefbdde25f5
Now that we are running the Victoria tests that include a
voting py38, we can now add the Python 3.8 metadata to the
package information to reflect that support.
Change-Id: I961af5693debacf7e29021a96e2c2b7d510da991
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Make a few cleanups:
- Remove python 2.7 stanza from setup.py
- Update requirements: Remove sphinx, it's not needed for testing, add
pygments which is really needed.
- Update doc/requirements: Remove python 2.7 support
- tox.ini: Remove testing of po files, the infra scripts do this since
a long time
- Update conf.py, no need to import openstackdocstheme anymore.
Change-Id: I9d030eb450f2c7ae74c25b7564a01b8785503e5e
python setup.py install fails due to https://review.opendev.org/#/c/694387
unable to copy missing file.
Change-Id: Ib02387c4be70581df64cf5009750b4f30ae30159
This reverts commit 2a28696de9e18a3866631507739944ceb3460872.
Devstack still references a number of these files; revert until
devstack incorporates removal.
Change-Id: I1e90ceee1f87291668e447f180f37bb809763836
Added new import method 'copy-image' which will copy existing image into
specified list of stores. Introduced additional task which will serve
as internal plugin which will allow copying existing image into staging
area and then this data will be uploaded to specified stores via regula
import flow.
NOTE: This new import method 'copy-image' is only supported if multiple
stores are enabled in deployment.
APIImpact
Implements: blueprint copy-existing-image
Change-Id: I13eaab7ab013f44ce18465bdbdbe8052942570ff
Instead of a default policy.json file, policy defaults are now defined
in code. An operator need not supply policy.json data except to the
extent they want to override the defaults. Currently an empty
policy.json is still shipped because it is expected by devstack, but
this can be removed later. A sample policy.yaml file can be generated
using the genpolicy tox environment.
This partly fulfils the requirements of the policy in code goal[1].
However, because policies don't map 1:1 with APIs, it will not be
possible to fully document the policies until changes are made in how
policies are applied as proposed in https://review.opendev.org/528021
Due to the fact that existing policy files may rely on a rule named
"default" to specifiy policies not explicitly listed in the policy.json
file, all policies that are not admin-only by default now default to
"rule:default", so that the "default" rule will continue to apply to
those policies that are not listed in policy.json.
To ensure that this yields the expected policy in a standard
policy-in-code config file, the default value of the "default" rule is
now the empty string "". This is a change; between the Queens release
and now the default was set to "role:admin" to match the value specified
in the default policy.json file. An installation relying on both the
"default" rule for some policies and the default value of the default
rule may end up with a more permissive policy after upgrading. It's
likely that no such policies exist in the wild, because prior to the
Queens release the default value for the "default" rule was "@" (allow
all requests), so anybody relying on this rule will surely have
specified it explicitly in their policy.json.
Policies whose default is "role:admin" no longer use the "default" rule.
Therefore existing policy.json files that rely on the "default" rule for
those policies, and who have specified a value for the "default" rule
that is more permissive, will result in a more restrictive policy after
upgrading. It is unlikely that any of these policies exist in the wild
either.
[1] https://governance.openstack.org/tc/goals/selected/queens/policy-in-code.html
Change-Id: I8d1ccf5844078cc0b1652fb1130794daf07cedbc
This patch introduced double registering of the same
config option groups which fails glance-api start
if reserved stores are actually defined.
The code utilizing these config options has not been
merged which prevented testing to catch this.
Closes-Bug: #1844108
This reverts commit 4265e61bc84ce9bd085a95d8734647f4875af740.
Change-Id: Iaf338d29673e68a15d37fdda81add552e4175634
Since we know the names of the reserved stores, we can add them
to the config file to make it easier for operators to configure
these things.
Includes deprecation of the 'work_dir' and 'node_staging_uri'
options.
Change-Id: I992cf468f9ce156ba51b1dd025459939acd8dce0
This will allow oslopolicy-policy-generator to generate useful
information about Glance policies.
Change-Id: I3aeeeb67d19832ad72f0ab06c8adc0b018020c71
Closes-Bug: #1816647
One of the community goals for Stein is to implement a command-line
tool for operators that runs programmable checks that might impact
upgradability.
This commit lays down the basic structure for the upgrade checks and
ties it up to `glance-status` command.
Change-Id: I7fcf5235a76d15dbcb2c49255bc26c2b586cd71c
Story: 2003657
Task: 26135
openstack-dev was decomissioned this night in https://review.openstack.org/621258
Update openstack-dev to openstack-discuss
Change-Id: I6b5a3489c3e09bc1413dbac174310339151df05b
https://review.openstack.org/527425 removed etc/rootwrap.conf, but
it did not remove its entry on setup.cfg. Thus, any attempt to do
"python setup.py install" will fail.
Change-Id: I041551fb6efb8fd52ff1eaa55f6b4af6738c4ded
In Python 3.7, "async" is a keyword. To prevent it from
conflicting, rename the async package to async_.
Change-Id: I1eaf87eedb86679d9ca9323aac05f0770c33efea
Closes-Bug: #1781617
At install_data hook, it tries to glance-image-import.conf which
does not exist. Since it is an optional file, let's not install it
by default.
Change-Id: I8a5122355da43c592b0cbad0eb7921875e0a5e99
This change adds 'web-download' Image Import method.
Changes discovery call returning actual enabled methods rather than
hardcoded value.
Change-Id: I3960d07cfa4e1be391f7a164147611724788d83e
Implements the spec Inject metadata properties automatically
to non-admin images
This commit adds new task '_InjectImageMetadata' to inject
the metadata properties automatically to non-admin images
at the time of creation of images using newly introduce
'image-import' api in v2.
DocImpact
Implements: I6a7ed31d5fae677cbbc9a6f6053f79d3e9326561
Change-Id: I98be97c42f23b60a72d520aad5f6078a96372c59
This change adds hooks for pulling in plugins for
Interoperable Image Import taksflow. Boilerplate Noop
plugin is provided as an example and for testing.
Change-Id: If14c7dc4f38360006f9cb350fbba54fa2f33be61
In order to make it simpler to use the default
configuration files when deploying services
from source, the files are added to pbr's
data_files section so that the files are
included in the built wheels and therefore
deployed with the code. Packaging and deployment
tools can then more easily use the default files
if they wish to.
This pattern is already established with similar
files for neutron and the glance metadefs as has
been mentioned in the related bug report.
Change-Id: Ie0eb7f16bc975de0db80a2144fd8db9e09f6317f
Closes-Bug: #1718356
The immediate cause was that the api_image_import flow was not
listed in the entrypoints in setup.cfg, so stevedore couldn't find
it. After the entrypoint was added, the task was going to failure
because it couldn't find the image_id. So this patch has the
import controller add the image_id to the task_input dict. Next
the flows were having trouble finding the image_id, so I just
passed it to them. There's probably a more elegant way to have
taskflow handle this, so this patch could use a refactoring. On
the plus side, the interoperable image import process does appear
to work with this patch.
NOTE: if you want to test this in devstack, use the stable/ocata
devstack but with the master branch of glance. The tasks engine
doesn't appear to be running under the Pike devstack configuration.
(Use defect 1712463 if you have an idea what might be the problem.)
Change-Id: Ic68c17f4cb671eb664e2de331787b55fe9878a27
Closes-bug: #1712462
A recent release of pbr explicitly requires stating which builders are
requested, rather than defaulting to html and man. This has resulted in
man pages not being built. Correct this oversight, along with a few
issues that have been introduced to 'doc/source/conf.py' since. It is
also necessary to remove a couple of plugins as there seems to be
another pbr bug under the hood. Fortunately none of these are used so
it's all good.
Change-Id: I22fd4d113704949dbf7704f50fa1d08fa10f11b6
Use autodoc_index_modules instead of autodoc_tree_index_modules so only
one copy of the API docs are generated.
Exclude the tests subpackage because it's not part of the Glance Python
API.
Exclude the glance.db.sqlalchemy subpackage to avoid issues caused when
parts of it cannot be imported during the doc build because they rely on
alembic setting up values that are not configured for a simple import.
Change-Id: I127b812bc879fc39533b39df1785d93835142430
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This change moves existing files, updates a few of the cross-references
and paths, and fixes some formatting. It is not meant to be the final
word on how the main page looks or how the other files are organized,
but it gets everything roughly into shape. If the glance team wants to
make changes, please do those as follow-up patches
This change depends on the spec and on a feature of pbr that allows us
to move where the auto-generated class reference documentation ends up
in the tree.
Depends-On: Ia750cb049c0f53a234ea70ce1f2bbbb7a2aa9454
Depends-On: I2bd5652bb59cbd9c939931ba2e7db1b37d2b30bb
Change-Id: I9dde267793a5913acb5b1ec028cfb66bc5189783
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit adds a pbr entrypoint for the wsgi script file. This enables
deploying glance as a proper wsgi application instead of a standalone
service.
Change-Id: I089a22a4be4227a551c32442dba27c426f54c87d
I3026ca6287a65ab5287bf3843f2a9d756ce15139 removed Glare from the Glance
codebase, but left some lines in setup.cfg.
This patch removes the remnant of the references in the code tree.
Co-Authored-By: Javier Pena <jpena@redhat.com>
Co-Authored-By: Nikhil Komawar <nik.komawar@gmail.com>
Depends-on: I02bfe805c419fcc49ac43b66f4f7b1a0d1d54755
Change-Id: Ia3652eb0dede3614cc4ea880f8ddc06c95740797
warnerrors used to show the errors in output when the docs generate
but now it looks like when this patch lands [0] it will cause the gate
to fail. I will push up a patch to fix all the docs problems but we
should revert this so we don't have a day when the gate is broken.
[0] https://review.openstack.org/#/c/229951
Change-Id: Ica33f1fd5acdc17a115d7a3bd81f8f4d79c1a809
No config generator hooks should ever be registered with a name that
belongs to another project. In this case, using oslo.middleware.cors
means that *every other project* that loads the middleware gets this
application's defaults when the generator is run on a system with
everything installed (such as a dev box with devstack). Use the name
of the app instead, to ensure that the defaults are only set when this
app's sample config and documentation are being generated.
Change-Id: I6a8c7d44b9db9325003ff2fdb667b0ced7739e96
Signed-off-by: Doug Hellmann <doug@doughellmann.com>