From 33e5737658815fa54fbff26db08ad59a7de96379 Mon Sep 17 00:00:00 2001 From: Julien Danjou Date: Wed, 7 Aug 2013 17:14:02 +0200 Subject: [PATCH] Stop using openstack.common.exception The openstack.common.exception has been deprecated and removed from oslo-incubator. Therefore, Heat should follow the recommendation and stop the usage of this file altogether. Change-Id: I0364da262d956cecea7b77ebc40ead8ece224828 Closes-Bug: #1208734 --- heat/db/sqlalchemy/migration.py | 2 +- heat/openstack/common/exception.py | 140 ----------------------------- openstack-common.conf | 1 - 3 files changed, 1 insertion(+), 142 deletions(-) delete mode 100644 heat/openstack/common/exception.py diff --git a/heat/db/sqlalchemy/migration.py b/heat/db/sqlalchemy/migration.py index fa0782f5ad..988002e9e2 100644 --- a/heat/db/sqlalchemy/migration.py +++ b/heat/db/sqlalchemy/migration.py @@ -22,7 +22,7 @@ import sqlalchemy import migrate from migrate.versioning import util as migrate_util -from heat.openstack.common import exception +from heat.common import exception from heat.openstack.common.db.sqlalchemy.session import get_engine from heat.openstack.common.gettextutils import _ diff --git a/heat/openstack/common/exception.py b/heat/openstack/common/exception.py deleted file mode 100644 index 9ba9fc1448..0000000000 --- a/heat/openstack/common/exception.py +++ /dev/null @@ -1,140 +0,0 @@ -# vim: tabstop=4 shiftwidth=4 softtabstop=4 - -# Copyright 2011 OpenStack Foundation. -# All Rights Reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); you may -# not use this file except in compliance with the License. You may obtain -# a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT -# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the -# License for the specific language governing permissions and limitations -# under the License. - -""" -Exceptions common to OpenStack projects -""" - -import logging - -_FATAL_EXCEPTION_FORMAT_ERRORS = False - - -class Error(Exception): - def __init__(self, message=None): - super(Error, self).__init__(message) - - -class ApiError(Error): - def __init__(self, message='Unknown', code='Unknown'): - self.message = message - self.code = code - super(ApiError, self).__init__('%s: %s' % (code, message)) - - -class NotFound(Error): - pass - - -class UnknownScheme(Error): - - msg = "Unknown scheme '%s' found in URI" - - def __init__(self, scheme): - msg = self.__class__.msg % scheme - super(UnknownScheme, self).__init__(msg) - - -class BadStoreUri(Error): - - msg = "The Store URI %s was malformed. Reason: %s" - - def __init__(self, uri, reason): - msg = self.__class__.msg % (uri, reason) - super(BadStoreUri, self).__init__(msg) - - -class Duplicate(Error): - pass - - -class NotAuthorized(Error): - pass - - -class NotEmpty(Error): - pass - - -class Invalid(Error): - pass - - -class BadInputError(Exception): - """Error resulting from a client sending bad input to a server""" - pass - - -class MissingArgumentError(Error): - pass - - -class DatabaseMigrationError(Error): - pass - - -class ClientConnectionError(Exception): - """Error resulting from a client connecting to a server""" - pass - - -def wrap_exception(f): - def _wrap(*args, **kw): - try: - return f(*args, **kw) - except Exception as e: - if not isinstance(e, Error): - #exc_type, exc_value, exc_traceback = sys.exc_info() - logging.exception(_('Uncaught exception')) - #logging.error(traceback.extract_stack(exc_traceback)) - raise Error(str(e)) - raise - _wrap.func_name = f.func_name - return _wrap - - -class OpenstackException(Exception): - """Base Exception class. - - To correctly use this class, inherit from it and define - a 'message' property. That message will get printf'd - with the keyword arguments provided to the constructor. - """ - message = "An unknown exception occurred" - - def __init__(self, **kwargs): - try: - self.kwargs = kwargs - self._error_string = self.message % kwargs - - except Exception as e: - if _FATAL_EXCEPTION_FORMAT_ERRORS: - raise e - else: - # at least get the core message out if something happened - self._error_string = self.message - - def __str__(self): - return self._error_string - - -class MalformedRequestBody(OpenstackException): - message = "Malformed message body: %(reason)s" - - -class InvalidContentType(OpenstackException): - message = "Invalid content type %(content_type)s" diff --git a/openstack-common.conf b/openstack-common.conf index deb0bbb782..e119cad917 100644 --- a/openstack-common.conf +++ b/openstack-common.conf @@ -4,7 +4,6 @@ module=db module=db.sqlalchemy module=eventlet_backdoor -module=exception module=excutils module=gettextutils module=importutils