openstack/heat
Code Issues Proposed changes

Correct the class equivalent judgement error

Browse Source 
for n, f in six.iteritems(self.functions):
            if not isinstance(f, hot_funcs.Removed):
                self._parser_condition_functions[n] = function.Invalid
            else:
                self._parser_condition_functions[n] = f

In the above codes, "f" is a class ,not an instance, therefore isinstance is uncorrect.

Change-Id: I9ec41d19b77acf6e083b7c5cb5b779dc54b4e547
This commit is contained in:
chenaidong1 2017-04-28 17:17:43 +08:00
parent 9f65b7dab5
commit 3431dfede2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
heat/engine/hot/template.py
View File

@ -479,7 +479,7 @@ class HOTemplate20161014(HOTemplate20160408):
self._parser_condition_functions = {}
for n, f in six.iteritems(self.functions):
if not isinstance(f, hot_funcs.Removed):
if not f == hot_funcs.Removed:
self._parser_condition_functions[n] = function.Invalid
else:
self._parser_condition_functions[n] = f